necouchman commented on code in PR #1087:
URL: https://github.com/apache/guacamole-client/pull/1087#discussion_r2112872702
##########
guacamole-ext/src/main/java/org/apache/guacamole/properties/GuacamoleProperty.java:
##########
@@ -39,7 +39,7 @@ public interface GuacamoleProperty<Type> {
* input string which match this pattern will not be included in the parsed
* result.
*/
- static final Pattern DELIMITER_PATTERN = Pattern.compile(";\\s*");
+ static final Pattern DELIMITER_PATTERN = Pattern.compile("[;,]\\s*");
Review Comment:
> Also, since whitespace characters cannot legally be included in any URI,
that's probably a better choice for the URIGuacamoleProperty separator than a
semicolon (which is legal in URIs).
So, for `URIGuacamoleProperty`, you're thinking just this:
```
static final Pattern DELIMITER_PATTERN = Pattern.compile("\\s*");
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
