On Mon, Jul 04, 2011 at 11:43:33AM +0200, Graham Leggett wrote: > I have already stated the basis for the veto: every single apparent > flaw in the apr_ldap code that caused wrowe to remove it from APR is > still present in the code that wrowe dumped into httpd.
It's incumbent on you to provide specific technical objections if vetoing code, not this hand-waving "objections must exist because of X". The removal from APR was because the API does not match design of the other APIs in APR, because it is an "incomplete abstraction" - mod_ldap must use the underlying LDAP API directly as well as the wrapper functions. This is not something which translates directly across to httpd; the exported API from mod_ldap was already an incomplete abstraction, adding more exports does not change that. Indeed, it explains the motivation for consolidating this stuff in one place. If you have specific concerns with exposing all the ap[r]_ldap_* API from httpd, then that is something we can maybe resolve; it looks like mod_authnz_ldap and mod_vhost_ldap only require the url_parse hook, so maybe we could cut the additional exported API back down to that? You allude to build issues without giving details, what's still broken? (Thanks Stefan for fixing my own screwup) Regards, Joe
