> On 7 Feb 2018, at 16:24, Graham Leggett <minf...@sharp.fm> wrote: > > On 07 Feb 2018, at 5:18 PM, Graham Leggett <minf...@sharp.fm> wrote: > >> Looking back through the archives, looks like that backport was already >> accepted: >> >> http://svn.apache.org/viewvc?view=revision&revision=1634520 > > Hmmm… it’s actually only solved the URL too long problem, the hostname too > long problem is still a fatal error: > > ptr = apr_uri_unparse(p, &uri, APR_URI_UNP_REVEALPASSWORD); > if (PROXY_STRNCPY(wshared->name, ptr) != APR_SUCCESS) { > ap_log_error(APLOG_MARK, APLOG_ERR, 0, ap_server_conf, APLOGNO(02808) > "Alert! worker name (%s) too long; truncated to: %s", ptr, > wshared->name > ); > } > if (PROXY_STRNCPY(wshared->scheme, uri.scheme) != APR_SUCCESS) { > return apr_psprintf(p, "worker scheme (%s) too long", uri.scheme); > } > if (PROXY_STRNCPY(wshared->hostname, uri.hostname) != APR_SUCCESS) { > return apr_psprintf(p, "worker hostname (%s) too long", uri.hostname); > } > > Would this break if we did the same warning on hostname that’s done on the > full URL?
Not sure how this broke on your end - but the cases where I had it break on me
in production where all cases where things were generated and dynamically
registered with some sort of ``service-zone-status-etc-<massively long ipv6
address>’’ thing:
casemo-apiservice-backend-frankfurt-production-W0091-2a01-4f80-0201-0000-32e6-0000-0000-0002
so chopping of the end is a bit painful.
Dw.
signature.asc
Description: Message signed with OpenPGP
