Guys, why we have 2 different inspection files in the repo? idea\ignite_inspections.xml idea\ignite_inspections_teamcity.xml
AFAIK TeamCity is able to use the same inspection file with IDE. I've imported 'idea\ignite_inspections.xml' in the IDE, but now see inspection warnings for my PR on TC because of different rules. On Sun, Nov 11, 2018 at 6:06 PM Maxim Muzafarov <maxmu...@gmail.com> wrote: > > Yakov, Dmitry, > > Which example of unsuccessful suite execution do we need? > Does the current fail [1] in the master branch enough to configure > notifications by TC.Bot? > > > Please consider adding more checks > > - line endings. I think we should only have \n > > - ensure blank line at the end of file > > It seems to me that `line endings` is easy to add, but for the `blank > line at the end` we need as special regexp. Can we focus on built-in > IntelliJ inspections at first and fix others special further? > > [1] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > On Sun, 11 Nov 2018 at 17:55, Maxim Muzafarov <maxmu...@gmail.com> wrote: > > > > Igniters, > > > > Since the inspection rules are included in RunAll a few members of the > > community mentioned a wide distributed execution time on TC agents: > > - 1h:27m:38s publicagent17_9094 > > - 38m:04s publicagent17_9094 > > - 33m:29s publicagent17_9094 > > - 17m:13s publicagent17_9094 > > It seems that we should configure the resources distribution across TC > > containers. Can anyone take a look at it? > > > > > > I've also prepared the short list of rules to work on: > > + Inconsistent line separators (6 matches) > > + Problematic whitespace (4 matches) > > + expression.equals("literal")' rather than > > '"literal".equals(expression) (53 matches) > > + Unnecessary 'null' check before 'instanceof' expression or call (42 > > matches) > > + Redundant 'if' statement (69 matches) > > + Redundant interface declaration (28 matches) > > + Double negation (0 matches) > > + Unnecessary code block (472 matches) > > + Line is longer than allowed by code style (2614 matches) (Is it > > possible to implement?) > > > > WDYT? > > > > On Fri, 26 Oct 2018 at 23:43, Dmitriy Pavlov <dpavlov....@gmail.com> wrote: > > > > > > Hi Maxim, > > > > > > thank you for your efforts to make this happen. Keep the pace! > > > > > > Could you please provide an example of how Inspections can fail, so I or > > > another contributor could implement support of these failures validation > > > in > > > the Tc Bot. > > > > > > Sincerely, > > > Dmitriy Pavlov > > > > > > пт, 26 окт. 2018 г. в 18:27, Yakov Zhdanov <yzhda...@apache.org>: > > > > > > > Maxim, > > > > > > > > Thanks for response, let's do it the way you suggested. > > > > > > > > Please consider adding more checks > > > > - line endings. I think we should only have \n > > > > - ensure blank line in the end of file > > > > > > > > All these are code reviews issues I pointed out many times when > > > > reviewing > > > > conributions. It would be cool if we have TC build failing if there is > > > > any. > > > > > > > > Thanks! > > > > > > > > --Yakov > > > > -- Best Regards, Vyacheslav D.
