See this reply https://lists.apache.org/thread.html/a08c9c77b9cce401043bc58cef303ed7501705e48243e17ec1a7f145@%3Clegal-discuss.apache.org%3E confirming we are OK including the code:
> > Now, this is precisely my plan. So -- it's perfectly fine to handle > > things this way: > > > > 1. Import 3rd party source code without a formal IP clearance and just > > reference the existing license info in the NOTICE file > > 2. Distribute the 3rd party source code with formal Apache releases > > and build binary plugin JARs ourselves. > > 3. Try to submit our fixes upstream. Perhaps highlight our changes to > > the 3rd party source code in the NOTICE file > > NOTICE is for legally-required attributions. But it's ok to include comments > about what you changed. From the alv2.0: "You may add Your own attribution > notices within Derivative Works that You distribute, alongside or as an > addendum to the NOTICE text from the Work, provided that such additional > attribution notices cannot be construed as modifying the License." > > 4. You didn't explicitly mention it, but do not change the headers in the > source. > > I'd say this is a good plan. So now it's just a matter of deciding if we include the plugins or not, but Apache 2.0 code should not be a problem as per the answer above. No IP clearance required, just a NOTICE update like we do for any new library. --emi On Tue, Oct 3, 2017 at 11:07 PM, Philippe Mouawad <[email protected]> wrote: > Hello, > Also one note on HTTP2. I didn't find any possibility to record http2 which > IMO is a mandatory feature. > > Oleg from HC project had pointed to a class that would have allowed this. > But on Jetty I don't see a way to do that. > > > Regards > > On Tue, Oct 3, 2017 at 9:37 PM, Emilian Bold <[email protected]> wrote: > >> > >> > I have already asked Andrei wether he would be ready to contribute it, at >> > that time he was not. >> > But maybe we can ask again. >> >> >> I will be asking again. >> >> > >> > > 1. https://lists.apache.org/thread.html/8db4686f7a2d98da66d57e7533eee1 >> > > 3f81d7ecf19afa293a7c26e99f@%3Clegal-discuss.apache.org%3E >> > > >> > I see the thread is big now :-) >> > So I wasn't wrong thinking it was not that easy >> >> >> As with anything Apache there are many opinions. I have yet to get a clear >> answer backed by some documentation. I think we will be fine using them. >> >> >> > Yes. But maybe on this topic, Emilian is doing something :-) >> >> Google Cloud next. Hopefully by November. >> >> >> >> >> --emi >> >> On Tue, Oct 3, 2017 at 10:33 PM, Philippe Mouawad < >> [email protected]> wrote: >> >> > On Tue, Oct 3, 2017 at 1:09 PM, Emilian Bold <[email protected]> >> > wrote: >> > >> > > I've asked legal-discuss@ [1] and will post back here with what I >> find. >> > > >> > > In the mean time I also believe it might not be out of the question for >> > CA >> > > Technologies to donate the code to the ASF. >> > >> > It would be the best option. >> > >> > >> > > I know some of the folks there >> > > are on the mailing list, perhaps we'll get some replies regarding this >> > > possibility. >> > > >> > >> > I hope so. >> > >> > > >> > > 1. https://lists.apache.org/thread.html/8db4686f7a2d98da66d57e7533eee1 >> > > 3f81d7ecf19afa293a7c26e99f@%3Clegal-discuss.apache.org%3E >> > > >> > >> > I see the thread is big now :-) >> > So I wasn't wrong thinking it was not that easy >> > >> > > >> > > --emi >> > > >> > > On Tue, Oct 3, 2017 at 1:59 PM, Philippe Mouawad < >> > > [email protected] >> > > > wrote: >> > > >> > > > On Tue, Oct 3, 2017 at 12:55 PM, Emilian Bold < >> [email protected]> >> > > > wrote: >> > > > >> > > > > > Correct me if I am wrong, if we plan to include the code of one >> of >> > > > those >> > > > > plugins, I don't see how we could without it being donated. >> > > > > >> > > > > Just like any dependency. I don't believe it's a rule that >> > dependencies >> > > > > have to be binary JARs. A "work" being "included" could mean source >> > > code, >> > > > > not just compiled JAR. >> > > > > >> > > > >> > > > As I am not sure I'll let legal answer >> > > > >> > > > > >> > > > > > If we are only including the binaries, then I don't see any >> benefit >> > > > from >> > > > > it, as it is already a plugin. >> > > > > >> > > > > Having something included in JMeter proper would at least guarantee >> > > some >> > > > > stability and security wrt the code >> > > > >> > > > >> > > > Absolutely >> > > > >> > > > > . >> > > > > >> > > > > A 3rd party plugin has no such guarantees. I personally don't like >> > > > hunting >> > > > > down plugins for my tools especially when it's not something niche. >> > > > > >> > > > >> > > > Absolutely >> > > > >> > > > > >> > > > > I don't believe JMeter should encourage users to always use >> plugins; >> > is >> > > > > JMeter something usable out of the box or just a platform? >> > > > > >> > > > >> > > > OOTB usable for me >> > > > >> > > > > >> > > > > I would gladly drop JDBC/MongoDB/JMS to have everything >> HTTP-related >> > > > > included. >> > > > > >> > > > >> > > > MongoDB is a good candidate. >> > > > I think JMS and JDBC are far from being a niche based on questions on >> > SO >> > > > for example. >> > > > >> > > > > >> > > > > --emi >> > > > > >> > > > > On Tue, Oct 3, 2017 at 1:41 PM, sebb <[email protected]> wrote: >> > > > > >> > > > > > If the code is available as a plugin then I don't see the need to >> > > > > > include it in JMeter itself. >> > > > > > It can be listed on a plugins page on the Wiki. >> > > > > > >> > > > > > Remember that code that is added to the JMeter code base adds to >> > the >> > > > > > ongoing maintenance cost. >> > > > > > This reduces the time that can be spent on the rest of the JMeter >> > > code. >> > > > > > >> > > > > > On 3 October 2017 at 11:27, Philippe Mouawad >> > > > > > <[email protected]> wrote: >> > > > > > > Hi Emilian, >> > > > > > > Correct me if I am wrong, if we plan to include the code of one >> > of >> > > > > those >> > > > > > > plugins, I don't see how we could without it being donated. >> > > > > > > I am not even sure that this project would be willing to donate >> > it. >> > > > > > > >> > > > > > > If we are only including the binaries, then I don't see any >> > benefit >> > > > > from >> > > > > > > it, as it is already a plugin. >> > > > > > > >> > > > > > > Maybe before going further, we should review the code to see if >> > it >> > > is >> > > > > > worth >> > > > > > > the discussion. >> > > > > > > >> > > > > > > Then we can ask Legal team, or feel free to ask. >> > > > > > > >> > > > > > > Regards >> > > > > > > >> > > > > > > On Tue, Oct 3, 2017 at 12:22 PM, Emilian Bold < >> > > > [email protected]> >> > > > > > > wrote: >> > > > > > > >> > > > > > >> IP clearance applies to donated code which will have an ASF >> > > license >> > > > > > header. >> > > > > > >> >> > > > > > >> For dependencies and included works this might help: >> > > > > > >> https://www.apache.org/legal/resolved.html#category-a >> > > > > > >> >> > > > > > >> FOR THE PURPOSES OF BEING INCLUDED IN AN APACHE PRODUCT, WHICH >> > > > > LICENSES >> > > > > > >>> ARE CONSIDERED TO BE SIMILAR IN TERMS TO THE APACHE LICENSE >> > 2.0? >> > > > > > >>> Works under the following licenses may be included within >> > Apache >> > > > > > products: >> > > > > > >>> >> > > > > > >> >> > > > > > >> >> > > > > > >> Apache License 2.0 >> > > > > > >> >> > > > > > >> >> > > > > > >> Please ask Apache legal because I don't believe there are any >> > > > > > restrictions. >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> --emi >> > > > > > >> >> > > > > > >> On Tue, Oct 3, 2017 at 12:49 PM, UBIK LOAD PACK Support < >> > > > > > >> [email protected]> wrote: >> > > > > > >> >> > > > > > >>> Hello, >> > > > > > >>> See: >> > > > > > >>> >> > > > > > >>> - https://incubator.apache.org/guides/ip_clearance.html >> > > > > > >>> >> > > > > > >>> Regards >> > > > > > >>> >> > > > > > >>> On Tuesday, October 3, 2017, Antonio Gomes Rodrigues < >> > > > > [email protected] >> > > > > > > >> > > > > > >>> wrote: >> > > > > > >>> >> > > > > > >>> > Hi, >> > > > > > >>> > >> > > > > > >>> > I'm also curious about why we could not integrate apache >> > > licensed >> > > > > > code. >> > > > > > >>> I >> > > > > > >>> > was thinking we can fork a plugin and integrate it in >> JMeter. >> > > > > > >>> > >> > > > > > >>> > Anybody have an idea? >> > > > > > >>> > >> > > > > > >>> > Antonio >> > > > > > >>> > >> > > > > > >>> > 2017-10-02 21:25 GMT+02:00 Philippe Mouawad < >> > > > > > [email protected] >> > > > > > >>> > <javascript:;>>: >> > > > > > >>> > >> > > > > > >>> > > On Mon, Oct 2, 2017 at 9:21 PM, Emilian Bold < >> > > > > > [email protected] >> > > > > > >>> > <javascript:;>> >> > > > > > >>> >> > > > > > >>> > > wrote: >> > > > > > >>> > > >> > > > > > >>> > > > > AFAIK, unless the project donates their code to >> JMeter, >> > > we >> > > > > > cannot >> > > > > > >>> > take >> > > > > > >>> > > it >> > > > > > >>> > > > as it would be a license infringement at minimum. >> > > > > > >>> > > > >> > > > > > >>> > > > It's open source under the Apache 2.0 license. The >> > license >> > > > > itself >> > > > > > >>> > allows >> > > > > > >>> > > > you to bundle it with JMeter proper. Of course, it >> won't >> > be >> > > > > > owned by >> > > > > > >>> > the >> > > > > > >>> > > > ASF but you can have it as a dependency. >> > > > > > >>> > > > >> > > > > > >>> > > > You could also "fork" it (or "vendor" it) if you want >> to >> > > add >> > > > > some >> > > > > > >>> > > patches. >> > > > > > >>> > > > >> > > > > > >>> > > >> > > > > > >>> > > AFAIK, we need for this the owner to make a donation as >> > piece >> > > > of >> > > > > > code >> > > > > > >>> is >> > > > > > >>> > > important. >> > > > > > >>> > > There is IP clearance process at Apache for that. I doubt >> > > that >> > > > we >> > > > > > can >> > > > > > >>> > take >> > > > > > >>> > > it as is or fork it, but I'm not an expert in those >> > matters. >> > > > > > >>> > > Maybe Andrei can tell us more. >> > > > > > >>> > > >> > > > > > >>> > > >> > > > > > >>> > > >> > > > > > >>> > > > Have there been any talks with CA Technologies / >> > Blazemeter >> > > > to >> > > > > > >>> perhaps >> > > > > > >>> > > > donate the plugin to the ASF? >> > > > > > >>> > > > >> > > > > > >>> > > > > Would you like to work on its implementation ? >> > > > > > >>> > > > >> > > > > > >>> > > > Why would I do that when you have this plugin available >> > > > under a >> > > > > > >>> > > compatible >> > > > > > >>> > > > license as well as this other one >> > > > > > >>> > > > https://github.com/syucream/jmeter-http2-plugin under >> > > Apache >> > > > > 2.0 >> > > > > > >>> based >> > > > > > >>> > > on >> > > > > > >>> > > > netty? >> > > > > > >>> > > > >> > > > > > >>> > > I tested this one, it does not work very well. >> > > > > > >>> > > Looks more like a POC than a stable implementation. >> > > > > > >>> > > >> > > > > > >>> > > >> > > > > > >>> > > >> > > > > > >>> > > > >> > > > > > >>> > > > >> > > > > > >>> > > > --emi >> > > > > > >>> > > > >> > > > > > >>> > > > On Mon, Oct 2, 2017 at 10:11 PM, Philippe Mouawad < >> > > > > > >>> > > > [email protected] <javascript:;>> wrote: >> > > > > > >>> > > > >> > > > > > >>> > > > > Hi Emilian, >> > > > > > >>> > > > > AFAIK, unless the project donates their code to >> JMeter, >> > > we >> > > > > > cannot >> > > > > > >>> > take >> > > > > > >>> > > it >> > > > > > >>> > > > > as it would be a license infringement at minimum. >> > > > > > >>> > > > > >> > > > > > >>> > > > > Regarding HTTP2 there are many options AFAIK: >> > > > > > >>> > > > > >> > > > > > >>> > > > > - Jetty >> > > > > > >>> > > > > - Netty >> > > > > > >>> > > > > - HC5 >> > > > > > >>> > > > > >> > > > > > >>> > > > > Would you like to work on its implementation ? >> > > > > > >>> > > > > >> > > > > > >>> > > > > >> > > > > > >>> > > > > Regards >> > > > > > >>> > > > > >> > > > > > >>> > > > > On Mon, Oct 2, 2017 at 8:54 PM, Emilian Bold < >> > > > > > >>> [email protected] >> > > > > > >>> > <javascript:;>> >> > > > > > >>> > > > > wrote: >> > > > > > >>> > > > > >> > > > > > >>> > > > > > Hello, >> > > > > > >>> > > > > > >> > > > > > >>> > > > > > I see we have a HTTP2 plugin >> > > > > > >>> > > > > > https://github.com/Blazemeter/jmeter-bzm-plugins >> > based >> > > > on >> > > > > > the >> > > > > > >>> > Jetty >> > > > > > >>> > > > > HTTP2 >> > > > > > >>> > > > > > support and under an Apache 2.0 license. >> > > > > > >>> > > > > > >> > > > > > >>> > > > > > Is there any reason JMeter could not bless this >> > > > > > implementation >> > > > > > >>> and >> > > > > > >>> > > > bundle >> > > > > > >>> > > > > > it? >> > > > > > >>> > > > > > >> > > > > > >>> > > > > > --emi >> > > > > > >>> > > > > > >> > > > > > >>> > > > > >> > > > > > >>> > > > > >> > > > > > >>> > > > > >> > > > > > >>> > > > > -- >> > > > > > >>> > > > > Cordialement. >> > > > > > >>> > > > > Philippe Mouawad. >> > > > > > >>> > > > > >> > > > > > >>> > > > >> > > > > > >>> > > >> > > > > > >>> > > >> > > > > > >>> > > >> > > > > > >>> > > -- >> > > > > > >>> > > Cordialement. >> > > > > > >>> > > Philippe Mouawad. >> > > > > > >>> > > >> > > > > > >>> > >> > > > > > >>> >> > > > > > >>> >> > > > > > >>> -- >> > > > > > >>> >> > > > > > >>> Regards >> > > > > > >>> Ubik Load Pack <http://ubikloadpack.com> Team >> > > > > > >>> Follow us on Twitter <http://twitter.com/ubikloadpack> >> > > > > > >>> >> > > > > > >>> >> > > > > > >>> Cordialement >> > > > > > >>> L'équipe Ubik Load Pack <http://ubikloadpack.com> >> > > > > > >>> Suivez-nous sur Twitter <http://twitter.com/ubikloadpack> >> > > > > > >>> >> > > > > > >> >> > > > > > >> >> > > > > > > >> > > > > > > >> > > > > > > -- >> > > > > > > Cordialement. >> > > > > > > Philippe Mouawad. >> > > > > > > Ubik-Ingénierie >> > > > > > > >> > > > > > > UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/> >> > > > > > > >> > > > > > > UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack> >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > Cordialement. >> > > > Philippe Mouawad. >> > > > >> > > >> > >> > >> > >> > -- >> > Cordialement. >> > Philippe Mouawad. >> > >> > > > > -- > Cordialement. > Philippe Mouawad.
