Thanks, Niket. I also agree with Jason that this is a public API despite the lack of command-line tool, so we do indeed need a KIP. :)
One minor point: I suspect that whatever we end up naming the additional fields here, should also be the name of the metrics in KIP-835. So if we go with a metric named "last-applied-offset" we'd want a lastAppliedOffset field here, and so on. I also wonder if it makes sense for us to report the timestamp of the latest batch that has been fetched (and not necessarily applied) rather than the wall clock time at which the leader made the latest fetch. If we take both timestamps directly from the metadata log, we know they'll be comparable even in the presence of clock skew. And we know because of KIP-835 that the metadata log won't go quiet for prolonged periods. best, Colin On Tue, May 10, 2022, at 13:30, Niket Goel wrote: >> @Niket does it make sense to add the Admin API to this KIP? > > Thanks Deng for pointing this out. I agree with Jason's suggestion. I will > go ahead and add the admin API to this KIP. > > - Niket > > On Tue, May 10, 2022 at 11:44 AM Jason Gustafson <ja...@confluent.io.invalid> > wrote: > >> > Hello Niket, currently DescribeQuorumResponse is not a public API, we >> don’t have a Admin api or shell script to get DescribeQuorumResponse, so >> it’s unnecessary to submit a KIP to change it, you can just submit a PR to >> accomplish this. >> >> Hey Ziming, I think it is public. It was documented in KIP-595 and we have >> implemented the API on the server. However, it looks like I never added >> the Admin API (even though it is assumed by the `kafka-metadata-quorum.sh` >> tool). @Niket does it make sense to add the Admin API to this KIP? >> >> Best, >> Jason >> >> On Mon, May 9, 2022 at 8:09 PM deng ziming <dengziming1...@gmail.com> >> wrote: >> >> > Hello Niket, currently DescribeQuorumResponse is not a public API, we >> > don’t have a Admin api or shell script to get DescribeQuorumResponse, so >> > it’s unnecessary to submit a KIP to change it, you can just submit a PR >> to >> > accomplish this. >> > >> > -- >> > Thanks >> > Ziming >> > >> > > On May 10, 2022, at 1:33 AM, Niket Goel <ng...@confluent.io.INVALID> >> > wrote: >> > > >> > > Hi all, >> > > >> > > I created a KIP to add some more information to >> > `DesscribeQuorumResponse` to enable ascertaining voter lag in the quorum >> a >> > little better. >> > > Please see KIP -- >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-836%3A+Additional+Information+in+DescribeQuorumResponse+about+Voter+Lag >> > > >> > > Thanks for your feedback, >> > > Niket Goel >> > >> > >> > > > -- > - Niket
