Hi,

Not sure we should do it for JAXB(and also jaxws). As in most case the jaxb/jaxws api(as in JDK6 it use jaxws/jaxb 2.1 but in most case we need use 2.2, and also the SPI mechanism of jaxws doesn't work in OSGi container) from jdk isn't much useful and so in Servicemix we shipped jaxb api/impl bundle and comment it out from jdk, so if customer need use jaxb in karaf, he need do a bit hack anyway.

Best Regards
Freeman
On 2011-8-30, at 下午3:25, Achim Nierbeck wrote:

Hi,

I suggest we do this also for the jaxb bundles since those are a real pain :)

regards, Achim

2011/8/30 Freeman Fang <freeman.f...@gmail.com>:
Hi,

This commit[1] also do same for JDK1.7.
I'd say other JDK API are quite stable but javax.annotation is a little bit
different so several other bundles(such as activemq, you can get more
details from [2]) which are popularly used in KARAF are explicitly specify javax.annotation import version as 1.1, and since JDK6, the javax.annotation
is 1.1 compatible, so in this case, if we don't provide this change,
customer need hack the jre.properties themselves.
But for other jdk packages, 3rd party bundle usually just import but without specified version, so the default export from system bundle 0 should be fine
IMHO.
[1]http://svn.apache.org/viewvc?rev=1162478&view=rev
[2]https://issues.apache.org/jira/browse/KARAF-835

Best Regards
Freeman




On 2011-8-30, at 下午12:30, Andreas Pieber wrote:

I'm a little bit curious because none of the other exported packages has a version; I'm basically not against adding versions here, but shouldn't we
do
the same for 1.5 and 1.7? Is there any way we can easily lookup which
versions are used by which JRE?

Kind regards,
Andreas

On Sun, Aug 28, 2011 at 05:46, <ff...@apache.org> wrote:

Author: ffang
Date: Sun Aug 28 03:46:53 2011
New Revision: 1162476

URL: http://svn.apache.org/viewvc?rev=1162476&view=rev
Log:
[KARAF-840]specify javax.annotation packages version to 1.1.0 for jre-1.6
as Annotation 1.1 Spec is used for Java 6

Modified:


karaf/branches/karaf-2.2.x/assemblies/apache-karaf/src/main/ filtered-resources/etc/jre.properties

Modified:

karaf/branches/karaf-2.2.x/assemblies/apache-karaf/src/main/ filtered-resources/etc/jre.properties
URL:

http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/assemblies/apache-karaf/src/main/filtered-resources/etc/jre.properties?rev=1162476&r1=1162475&r2=1162476&view=diff


= = = = = = = = = = = ===================================================================
---

karaf/branches/karaf-2.2.x/assemblies/apache-karaf/src/main/ filtered-resources/etc/jre.properties
(original)
+++

karaf/branches/karaf-2.2.x/assemblies/apache-karaf/src/main/ filtered-resources/etc/jre.properties
Sun Aug 28 03:46:53 2011
@@ -153,8 +153,8 @@ jre-1.6= \
javax.accessibility, \
javax.activation, \
javax.activity, \
- javax.annotation, \
- javax.annotation.processing, \
+ javax.annotation;version="1.1", \
+ javax.annotation.processing;version="1.1", \
javax.crypto, \
javax.crypto.interfaces, \
javax.crypto.spec, \




---------------------------------------------
Freeman Fang

FuseSource
Email:ff...@fusesource.com
Web: fusesource.com
Twitter: freemanfang
Blog: http://freemanfang.blogspot.com













--
--
*Achim Nierbeck*


Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
Committer & Project Lead
blog <http://notizblog.nierbeck.de/>

---------------------------------------------
Freeman Fang

FuseSource
Email:ff...@fusesource.com
Web: fusesource.com
Twitter: freemanfang
Blog: http://freemanfang.blogspot.com









Reply via email to