> On June 18, 2015, 7:29 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java, > > line 42 > > <https://reviews.apache.org/r/35590/diff/1/?file=986668#file986668line42> > > > > Do we need to make a REST call from the server itself? Doesn't seem > > right.
Seemed like the neatest way to check if endpoints are up. Do you have anything in mind ? - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35590/#review88346 ----------------------------------------------------------- On June 18, 2015, 2:23 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35590/ > ----------------------------------------------------------- > > (Updated June 18, 2015, 2:23 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens service health status. > > https://issues.apache.org/jira/browse/LENS-477 > > Initial patch for LENS-477. > We should list all other API/Endpoints etc that should be considered for > health checks. > > Current checks implemented- > curl http://localhost:9999/admin/healthcheck > {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}} > > > Diffs > ----- > > lens-server/pom.xml bb12e00 > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesAdminStatusCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesMetastoreCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServicesQueryApiCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 9ae0d66 > > Diff: https://reviews.apache.org/r/35590/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
