----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35590/#review90328 -----------------------------------------------------------
lens-server/pom.xml (line 245) <https://reviews.apache.org/r/35590/#comment143342> Is this dependency required? lens-server/src/main/java/org/apache/lens/server/LensService.java (line 431) <https://reviews.apache.org/r/35590/#comment143343> Instead of simple boolean status of healthy or not, let it give isHealthy or not, along with details of what is not healthy. Something like HealthStatus { boolean healthy; String details; } lens-server/src/main/java/org/apache/lens/server/healthcheck/LensAdminStatusCheck.java (line 41) <https://reviews.apache.org/r/35590/#comment143344> This doesnt seem reasonable to be here - hitting the same server through end point. - Amareshwari Sriramadasu On June 21, 2015, 3:45 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35590/ > ----------------------------------------------------------- > > (Updated June 21, 2015, 3:45 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens service health status. > > https://issues.apache.org/jira/browse/LENS-477 > > Initial patch for LENS-477. > We should list all other API/Endpoints etc that should be considered for > health checks. > > Current checks implemented- > curl http://localhost:9999/admin/healthcheck > {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}} > > > Diffs > ----- > > lens-server/pom.xml bb12e00 > lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensAdminStatusCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensMetastoreCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensQueryApiCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 07e20dc > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 9ae0d66 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 8a1b7c8 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > 89cfe71 > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 32feeb9 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > fa061ec > > Diff: https://reviews.apache.org/r/35590/diff/ > > > Testing > ------- > > > Thanks, > > Yash Sharma > >
