> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote: > > Can you add unit tests?
Added testcase but was stumbling on checking for -ve scenario. Wondering what is the best way to kill services-> check health-> bring them back up ? > On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthStatus.java, > > line 31 > > <https://reviews.apache.org/r/35590/diff/3/?file=999099#file999099line31> > > > > Use lombak Getters instead +1 > On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, > > line 1436 > > <https://reviews.apache.org/r/35590/diff/3/?file=999104#file999104line1436> > > > > Will this ever return null? Now check is moved to Catch block directly. > On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java, > > line 266 > > <https://reviews.apache.org/r/35590/diff/3/?file=999105#file999105line266> > > > > Can we add checks for EventService and MetricsService as well? Implemented. > On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 2311 > > <https://reviews.apache.org/r/35590/diff/3/?file=999106#file999106line2311> > > > > Can we add one check for estimation threadpool as well? Implemented. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35590/#review90436 ----------------------------------------------------------- On July 16, 2015, 6:18 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35590/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 6:18 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens service health status. > > https://issues.apache.org/jira/browse/LENS-477 > > Initial patch for LENS-477. > We should list all other API/Endpoints etc that should be considered for > health checks. > > Current checks implemented- > curl http://localhost:9999/admin/healthcheck > {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}} > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java > 74cc00c > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71128b7 > lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java > 5855ac6 > lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a > > lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > c5e1c14 > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 39f9f52 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > a778a1f > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > 89cfe71 > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 32feeb9 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 3a8fc95 > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35590/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.589 > s] > [INFO] Lens ............................................... SUCCESS [ 3.790 > s] > [INFO] Lens API ........................................... SUCCESS [ 20.511 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 20.891 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:41 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 20.744 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 17.011 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:40 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.243 > s] > [INFO] Lens Server ........................................ SUCCESS [05:18 > min] > [INFO] Lens client ........................................ SUCCESS [ 35.673 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:08 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.318 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.788 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:34 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.502 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.451 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:37 min > [INFO] Finished at: 2015-07-16T11:36:36+05:30 > [INFO] Final Memory: 127M/356M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
