----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35590/#review90436 -----------------------------------------------------------
Can you add unit tests? lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthStatus.java (line 31) <https://reviews.apache.org/r/35590/#comment143478> Use lombak Getters instead lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 1436) <https://reviews.apache.org/r/35590/#comment143479> Will this ever return null? lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java (line 266) <https://reviews.apache.org/r/35590/#comment143481> Can we add checks for EventService and MetricsService as well? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 2311) <https://reviews.apache.org/r/35590/#comment143480> Can we add one check for estimation threadpool as well? - Amareshwari Sriramadasu On July 4, 2015, 8:31 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35590/ > ----------------------------------------------------------- > > (Updated July 4, 2015, 8:31 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens service health status. > > https://issues.apache.org/jira/browse/LENS-477 > > Initial patch for LENS-477. > We should list all other API/Endpoints etc that should be considered for > health checks. > > Current checks implemented- > curl http://localhost:9999/admin/healthcheck > {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}} > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a > > lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthStatus.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 07e20dc > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 39f9f52 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 429b262 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > 89cfe71 > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 32feeb9 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 36adee0 > > Diff: https://reviews.apache.org/r/35590/diff/ > > > Testing > ------- > > {"metastore":{"healthy":true},"query":{"healthy":true},"quota":{"healthy":true},"scheduler":{"healthy":true},"session":{"healthy":true}} > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.406 > s] > [INFO] Lens ............................................... SUCCESS [ 3.076 > s] > [INFO] Lens API ........................................... SUCCESS [ 21.916 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 24.478 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:27 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 21.254 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 16.945 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:42 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 39.914 > s] > [INFO] Lens Server ........................................ SUCCESS [05:47 > min] > [INFO] Lens client ........................................ SUCCESS [ 41.465 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:17 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.659 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.244 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:24 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.815 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.904 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:06 min > [INFO] Finished at: 2015-07-04T13:54:16+05:30 > [INFO] Final Memory: 125M/400M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
