> On July 6, 2015, 4:54 a.m., Amareshwari Sriramadasu wrote: > > Can you add unit tests? > > Yash Sharma wrote: > Added testcase but was stumbling on checking for -ve scenario. > Wondering what is the best way to kill services-> check health-> bring > them back up ?
May be you can add test in TestServerRestart. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35590/#review90436 ----------------------------------------------------------- On July 17, 2015, 6:59 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35590/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 6:59 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens service health status. > > https://issues.apache.org/jira/browse/LENS-477 > > Initial patch for LENS-477. > We should list all other API/Endpoints etc that should be considered for > health checks. > > Current checks implemented- > curl http://localhost:9999/admin/healthcheck > {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}} > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java > 74cc00c > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71128b7 > lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java > 5855ac6 > lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a > > lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > c5e1c14 > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 39f9f52 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 3511236 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > 89cfe71 > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 32feeb9 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 3a8fc95 > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35590/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.821 > s] > [INFO] Lens ............................................... SUCCESS [ 2.711 > s] > [INFO] Lens API ........................................... SUCCESS [ 18.261 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 19.128 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:32 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 18.811 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 14.330 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:28 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.381 > s] > [INFO] Lens Server ........................................ SUCCESS [04:58 > min] > [INFO] Lens client ........................................ SUCCESS [ 37.044 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:06 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.153 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.328 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:20 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.598 > s] > [INFO] Lens Regression .................................... SUCCESS [ 11.416 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:25 min > [INFO] Finished at: 2015-07-18T00:11:59+05:30 > [INFO] Final Memory: 130M/402M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
