See below > On Jan 28, 2022, at 8:26 AM, Volkan Yazıcı <vol...@yazi.ci> wrote: > > I totally agree with Carter's points. > > Given the current state of discussion, I propose the following: > > - Every changes goes into a PR
+1 > - Merge requires a successful CI build +1 > - Merge requires at least one “approval” -1 I agree with Gary on this. I do not want to move to full RTC. > > Here "approval" can be fulfilled by following means: > > - The committer himself (that is, in practice, no approval/review is > needed) Say what? I wasn’t aware you could approve your own stuff. I guess that negates the -1 but I don’t see the point. I’d want to verify that you can approve your own stuff before doing this. > - By required reviewers + (optional) time-window (on timeout, issuer can > approve himself and get it merged) > > Is this something we can all agree on? > > Gary, if I am not mistaken, all this approach asks from you in addition to > what you are already doing is PR + CI checks. Is that a compromise you can > make? > > Ralph, I have read your remark about waiting for the next online meeting, > but that is on Feb 27, and I think we better shouldn't wait for a month to > get this rolling. That is actually a PMC meeting. If we were going to discuss this on a video call It should be open to anyone to attend. Ralph
