Look at the actual change in question,

It is not "missing" tests and cannot be tested.

It is a guard against jvm bugs like buggy G1GC collector.

On Sat, Dec 6, 2014 at 11:25 PM, Michael Wechner
<michael.wech...@wyona.com> wrote:
> Hi
>
> Yesterday "morning" I have noticed the following changes
>
> - lucene/core/src/java/org/apache/lucene/index/ConcurrentMergeScheduler.java
> - lucene/core/src/java/org/apache/lucene/index/MergePolicy.java
> -
> lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java
>
> and with these modifications also CHANGES.txt was updated.
>
> Yesterday "afternoon" I have noticed the following change
>
> - lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
>
> but this time CHANGES.txt was not updated (also
> lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java was not
> updated).
>
> As written in a previous email I am trying to test changes incrementally,
> hence I was wondering whether it would be helpful, that such a system for
> incremental testing would also point out things like maybing missing
> updates, like for example for CHANGES.txt or associated tests.
>
> But in order to do so, the system should implement some kind of rule, hence
> I was wondering what the rule is about CHANGES.txt?
>
> I know it sounds a bit like parents saying "hey, have you brushed your
> teeth?!" and it can be rather annoying, but it can also be very useful for
> the future having good teeth :-)
>
> Thanks
>
> Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to