https://issues.apache.org/jira/browse/LUCENE-8090 and https://issues.apache.org/jira/browse/SOLR-11740 are now resolved, so as far as I know there are no more blockers. I will build a RC tomorrow.
Le lun. 11 déc. 2017 à 11:33, Adrien Grand <jpou...@gmail.com> a écrit : > We have another blocker: https://issues.apache.org/jira/browse/LUCENE-8090 > . > > Could someone help Varun investigate > https://issues.apache.org/jira/browse/SOLR-11740? I just made it a > blocker as well until we know more about it. > > Le sam. 9 déc. 2017 à 08:57, Varun Thacker <va...@vthacker.in> a écrit : > >> This fails for me every single time : >> https://issues.apache.org/jira/browse/SOLR-11740 >> >> Can someone with more knowledge of the bin/solr script confirm if this >> effects the "-e cloud" command only or is it more widespread . >> That might help determine if we want to fix this before the release. >> >> On Fri, Dec 8, 2017 at 10:41 AM, Adrien Grand <jpou...@gmail.com> wrote: >> >>> FYI we are backporting SOLR-11423 >>> <https://issues.apache.org/jira/browse/SOLR-11423> to 7.2 so I'll build >>> a RC on Monday (assuming it will have been backported by then). >>> >>> Le jeu. 7 déc. 2017 à 20:17, Adrien Grand <jpou...@gmail.com> a écrit : >>> >>>> OK, it looks like all changes that we wanted to be included are now in? >>>> Please let me know if there is still something left to include in 7.2 >>>> before building a RC. >>>> >>>> I noticed SOLR-11423 is in a weird state, it is included in the >>>> changelog in 7.1 but has only been committed to master. Did we forget to >>>> backport it? >>>> >>>> Le mer. 6 déc. 2017 à 21:13, Andrzej Białecki < >>>> andrzej.biale...@lucidworks.com> a écrit : >>>> >>>>> On 6 Dec 2017, at 18:45, Andrzej Białecki < >>>>> andrzej.biale...@lucidworks.com> wrote: >>>>> >>>>> I attached the patch to SOLR-11714, which disables the ‘searchRate’ >>>>> trigger - if there are no objections I’ll commit it shortly to branch_7.2. >>>>> >>>>> >>>>> >>>>> This has been committed now to branch_7_2 and I don’t have any other >>>>> open issues for 7.2. Thanks! >>>>> >>>>> >>>>> >>>>> On 6 Dec 2017, at 15:51, Andrzej Białecki < >>>>> andrzej.biale...@lucidworks.com> wrote: >>>>> >>>>> >>>>> On 6 Dec 2017, at 15:35, Andrzej Białecki < >>>>> andrzej.biale...@lucidworks.com> wrote: >>>>> >>>>> SOLR-11458 is committed and resolved - thanks for the patience. >>>>> >>>>> >>>>> >>>>> Actually, one more thing … ;) SOLR-11714 is a more serious bug in a >>>>> new feature (searchRate autoscaling trigger). It’s probably best to >>>>> disable >>>>> this feature in 7.2 rather than releasing a broken version, so I’d like to >>>>> commit a patch that disables it (plus a note in CHANGES.txt). >>>>> >>>>> >>>>> >>>>> >>>>> On 6 Dec 2017, at 14:02, Adrien Grand <jpou...@gmail.com> wrote: >>>>> >>>>> Thanks for the heads up, Anshum. >>>>> >>>>> This leaves us with only SOLR-11458 to wait for before building a RC >>>>> (which might be ready but just not marked as resolved). >>>>> >>>>> >>>>> >>>>> Le mer. 6 déc. 2017 à 13:47, Ishan Chattopadhyaya < >>>>> ichattopadhy...@gmail.com> a écrit : >>>>> >>>>>> Hi Adrien, >>>>>> I'm planning to skip SOLR-11624 for this release (as per my last >>>>>> comment >>>>>> https://issues.apache.org/jira/browse/SOLR-11624?focusedCommentId=16280121&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16280121). >>>>>> If someone has an objection, please let me know; otherwise, please feel >>>>>> free to proceed with the release. >>>>>> I'll continue working on it anyway, and shall try to have it ready >>>>>> for the next release. >>>>>> Thanks, >>>>>> Ishan >>>>>> >>>>>> On Wed, Dec 6, 2017 at 2:41 PM, Adrien Grand <jpou...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> FYI I created the new branch for 7.2, so you will have to backport >>>>>>> to this branch. No hurry though, I mostly created the branch so that >>>>>>> it's >>>>>>> fine to cherry-pick changes that may wait for 7.3 to be released. >>>>>>> >>>>>>> Le mer. 6 déc. 2017 à 08:53, Adrien Grand <jpou...@gmail.com> a >>>>>>> écrit : >>>>>>> >>>>>>>> Sorry to hear that Ishan, I hope you are doing better now. +1 to >>>>>>>> get SOLR-11624 in. >>>>>>>> >>>>>>>> Le mer. 6 déc. 2017 à 07:57, Ishan Chattopadhyaya < >>>>>>>> ichattopadhy...@gmail.com> a écrit : >>>>>>>> >>>>>>>>> I was a bit unwell over the weekend and yesterday; I'm working on >>>>>>>>> a very targeted fix for SOLR-11624 right now; I expect it to take >>>>>>>>> another >>>>>>>>> 5-6 hours. >>>>>>>>> Is that fine with you, Adrien? If not, please go ahead with the >>>>>>>>> release, and I'll volunteer later for a bugfix release for this after >>>>>>>>> 7.2 >>>>>>>>> is out. >>>>>>>>> >>>>>>>>> On Wed, Dec 6, 2017 at 3:25 AM, Adrien Grand <jpou...@gmail.com> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Fine with me. >>>>>>>>>> >>>>>>>>>> Le mar. 5 déc. 2017 à 22:34, Varun Thacker <va...@vthacker.in> a >>>>>>>>>> écrit : >>>>>>>>>> >>>>>>>>>>> Hi Adrien, >>>>>>>>>>> >>>>>>>>>>> I'd like to commit SOLR-11590 . The issue had a patch couple of >>>>>>>>>>> weeks ago and has been reviewed but never got committed. I've run >>>>>>>>>>> all the >>>>>>>>>>> tests twice as well to verify. >>>>>>>>>>> >>>>>>>>>>> On Tue, Dec 5, 2017 at 9:08 AM, Andrzej Białecki < >>>>>>>>>>> andrzej.biale...@lucidworks.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 5 Dec 2017, at 18:05, Adrien Grand <jpou...@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Andrzej, ok to merge since it is a bug fix. Since we're close >>>>>>>>>>>> to the RC build, maybe try to get someone familiar with the code >>>>>>>>>>>> to review >>>>>>>>>>>> it to make sure it doesn't have unexpected side-effects? >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Sure I’ll do this - thanks! >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Le mar. 5 déc. 2017 à 17:57, Andrzej Białecki < >>>>>>>>>>>> andrzej.biale...@lucidworks.com> a écrit : >>>>>>>>>>>> >>>>>>>>>>>>> Adrien, >>>>>>>>>>>>> >>>>>>>>>>>>> If it’s ok I would also like to merge SOLR-11458, this >>>>>>>>>>>>> significantly reduces the chance of accidental data loss when >>>>>>>>>>>>> using >>>>>>>>>>>>> MoveReplicaCmd. >>>>>>>>>>>>> >>>>>>>>>>>>> On 5 Dec 2017, at 14:44, Adrien Grand <jpou...@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Quick update: >>>>>>>>>>>>> >>>>>>>>>>>>> LUCENE-8043, SOLR-9137, SOLR-11662 and SOLR-11687 have been >>>>>>>>>>>>> merged, they will be in 7.2. >>>>>>>>>>>>> >>>>>>>>>>>>> LUCENE-8048 and SOLR-11624 are still open. >>>>>>>>>>>>> >>>>>>>>>>>>> LUCENE-8048 looks like it could make things better in some >>>>>>>>>>>>> cases but I don't think it is required for 7.2, so I don't plan >>>>>>>>>>>>> to hold the >>>>>>>>>>>>> release on it. >>>>>>>>>>>>> >>>>>>>>>>>>> SOLR-11624 looks bad, I'll wait for it. >>>>>>>>>>>>> >>>>>>>>>>>>> Le mar. 5 déc. 2017 à 07:45, Noble Paul <noble.p...@gmail.com> >>>>>>>>>>>>> a écrit : >>>>>>>>>>>>> >>>>>>>>>>>>>> +1 this is over due >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Dec 4, 2017 16:38, "Varun Thacker" <va...@vthacker.in> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> +1 Adrien ! Thanks for taking it up >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Fri, Dec 1, 2017 at 9:05 AM, Christine Poerschke >>>>>>>>>>>>>> (BLOOMBERG/ QUEEN VIC) <cpoersc...@bloomberg.net> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> I'd like to see >>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/SOLR-9137 included in >>>>>>>>>>>>>>> the release. Hoping to commit it on/by Tuesday. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Christine >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> From: dev@lucene.apache.org At: 12/01/17 10:11:59 >>>>>>>>>>>>>>> To: dev@lucene.apache.org >>>>>>>>>>>>>>> Subject: Lucene/Solr 7.2 >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hello, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> It's been more than 6 weeks since we released 7.1 and we >>>>>>>>>>>>>>> accumulated a good set of changes, so I think we should release >>>>>>>>>>>>>>> Lucene/Solr >>>>>>>>>>>>>>> 7.2.0. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> There is one change that I would like to have before >>>>>>>>>>>>>>> building a RC: LUCENE-8043[1], which looks like it is almost >>>>>>>>>>>>>>> ready to be >>>>>>>>>>>>>>> merged. Please let me know if there are any other changes that >>>>>>>>>>>>>>> should make >>>>>>>>>>>>>>> it to the release. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I volunteer to be the release manager. I'm currently >>>>>>>>>>>>>>> thinking of building the first release candidate next >>>>>>>>>>>>>>> wednesday, December >>>>>>>>>>>>>>> 6th. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/LUCENE-8043 >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> >>