Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/385#discussion_r191403264
--- Diff: solr/solrj/src/java/org/apache/solr/common/SolrDocument.java ---
@@ -373,6 +374,23 @@ public int size() {
return _fields.values();
}
+ public Map<String, Object> getChildDocumentsMap() {
--- End diff --
This method is tempting; it's unsurprising you added it, but I'd rather we
not have it. It's not particularly cheap; raises questions of mutability, and
it's really not necessary; only one caller (for indexing, recunwrap) needs this
algorithm; and it need not build up some HashMap as we see here to do its job.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
