Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/385#discussion_r191780669
  
    --- Diff: solr/core/src/test/org/apache/solr/update/AddBlockUpdateTest.java 
---
    @@ -693,7 +668,6 @@ private void 
indexSolrInputDocumentsDirectly(List<SolrInputDocument> docs) throw
           h.getCore().getUpdateHandler().addDoc(updateCmd);
           updateCmd.clear();
         }
    -    assertU(commit());
    --- End diff --
    
    this part was fine, especially for nested docs since we want there to be a 
higher likelihood of more segments since if there's a bug pertaining to not 
adding docs in a block, then more segments will help prove this out.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to