Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/385#discussion_r191776629
  
    --- Diff: solr/core/src/test/org/apache/solr/update/AddBlockUpdateTest.java 
---
    @@ -550,14 +531,8 @@ public void testJavaBinCodecNestedRelation() throws 
IOException {
         try (JavaBinCodec jbc = new JavaBinCodec(); InputStream is = new 
ByteArrayInputStream(buffer)) {
           result = (SolrInputDocument) jbc.unmarshal(is);
         }
    -    assertEquals(2 + childsNum, result.size());
    -    assertEquals("v1", result.getFieldValue("parent_f1"));
    -    assertEquals("v2", result.getFieldValue("parent_f2"));
    -
    -    for(Map.Entry<String, SolrInputDocument> entry: children.entrySet()) {
    -      compareSolrInputDocument(entry.getValue(), 
result.getFieldValue(entry.getKey()));
    -    }
     
    +    assertTrue(compareSolrInputDocument(topDocument, result));
    --- End diff --
    
    cool; you're teaching this old dog some new tricks :-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to