Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/385#discussion_r191779761
--- Diff:
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java ---
@@ -417,7 +417,8 @@ private void addAndDelete(AddUpdateCommand cmd,
List<UpdateLog.DBQ> deletesAfter
}
private Term getIdTerm(AddUpdateCommand cmd) {
--- End diff --
I think it's trappy/dangerous to invoke getDocsList() which is an innocent
looking getter that actually flattens the input and caches it rendering any
possible further changes to the unflattend docs silently ignored. Can you
change this method to accept the List of flattened documents as its argument?
And change getDocsList to not cache the result and be named something like
computeFlattenedDocs()
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
