Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/385#discussion_r191782336
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -228,11 +225,25 @@ private void buildDocsList() {
return unwrappedDocs;
}
+ private static Collection<String>
getChildDocumentsKeys(SolrInputDocument doc) {
--- End diff --
But this is only called in one place; no? I think it's better if
recUnwrapRelations does this logic itself as it avoids the intermediate HashSet.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
