https://issues.apache.org/jira/browse/LUCENE-9443 This regression on the highlighter is trivial; just revert a commit to a file and maybe suppress a warning. I'll get this into 8.6.1 today.
~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Wed, Jul 29, 2020 at 6:04 AM Jan Høydahl <[email protected]> wrote: > Merged! > > 28. jul. 2020 kl. 23:22 skrev Houston Putman <[email protected]>: > > +1 to the change. > > I think the last issue remaining is Jan's Zookeeper client port fix. After > that is merged I will start with the release. > > - Houston > > On Tue, Jul 28, 2020 at 5:12 PM Gus Heck <[email protected]> wrote: > >> Ishan suggested I also supply the slight clarification to ref guide build >> docs to 8_6 https://github.com/apache/lucene-solr/pull/1704 if you want >> to include it. >> >> On Mon, Jul 27, 2020 at 9:25 PM Houston Putman <[email protected]> >> wrote: >> >>> Both of those look good to include! >>> >>> Ill keep an eye out for when they get resolved. >>> >>> - Houston >>> >>> On Mon, Jul 27, 2020 at 9:16 PM Ishan Chattopadhyaya < >>> [email protected]> wrote: >>> >>>> Can we include SOLR-11611 for 8.6.1? The patch should be simple to test >>>> out (with someone having a Windows machine and VM) and seems like a good >>>> one to fix. >>>> I marked it as a 8.6.1 bug, but please feel free to unmark it (or I can >>>> do so, if you tell me to) if you feel otherwise. >>>> >>>> On Tue, Jul 28, 2020 at 5:40 AM Jan Høydahl <[email protected]> >>>> wrote: >>>> >>>>> Came back from holiday and fixed >>>>> https://issues.apache.org/jira/browse/SOLR-14671 >>>>> Can we include it in 8.6.1? >>>>> >>>>> Jan >>>>> >>>>> 27. jul. 2020 kl. 22:56 skrev Houston Putman <[email protected] >>>>> >: >>>>> >>>>> Added upgrade notes for the autoscaling stuff. >>>>> >>>>> Will begin the release process tomorrow when my GPG Keys will be >>>>> refreshed in all of the apache systems. >>>>> >>>>> - Houston >>>>> >>>>> On Mon, Jul 27, 2020 at 4:41 PM Gus Heck <[email protected]> wrote: >>>>> >>>>>> Doc changes are in. Still having trouble with that one link in 8x but >>>>>> just fixed it locally and made sure not to push that change. >>>>>> >>>>>> On Mon, Jul 27, 2020 at 12:57 PM Gus Heck <[email protected]> wrote: >>>>>> >>>>>>> 8x docs not building smoothly on my laptop... (without changes) >>>>>>> troubleshooting, checking deps listed in README.adoc, etc. >>>>>>> >>>>>>> On Mon, Jul 27, 2020 at 11:50 AM Houston Putman < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Yeah, push it to branch_8_6. I have to document the upgrade notes >>>>>>>> for the autoscaling stuff anyways. >>>>>>>> >>>>>>>> On Mon, Jul 27, 2020 at 11:27 AM Gus Heck <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> I realized after I went looking for it in the new docs that I >>>>>>>>> didn't actually push the doc changes for MOVEREPLICA to 8x (had >>>>>>>>> intended to >>>>>>>>> verify that nothing differed in 8x before pushing). Doing that now, >>>>>>>>> and >>>>>>>>> suspect that we probably want to include it for 8.6.1 >>>>>>>>> >>>>>>>>> On Sat, Jul 25, 2020 at 10:20 PM Varun Thacker <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> > does the default autoscaling policy stay once they have >>>>>>>>>> upgraded? >>>>>>>>>> >>>>>>>>>> Looking at >>>>>>>>>> https://github.com/apache/lucene-solr/commit/8e0eae2/#diff-de88ca16848af57d2474e04e26ea462cR90 >>>>>>>>>> , it seems like just upgrading to Solr 8.6.1 will be enough. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Jul 24, 2020 at 1:51 PM Houston Putman < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> So it looks like we all agree that 8.6.1 should be cut to fix >>>>>>>>>>> this issue. >>>>>>>>>>> >>>>>>>>>>> Unless there's any alternatives proposed, early next week I'm >>>>>>>>>>> going to push my branch_8_6 that has the offending commits reverted >>>>>>>>>>> and >>>>>>>>>>> some additional documentation on reverting the defaulted >>>>>>>>>>> autoscaling policy >>>>>>>>>>> from 8.6.0. >>>>>>>>>>> >>>>>>>>>>> Then I'll start the release process for 8.6.1. >>>>>>>>>>> >>>>>>>>>>> Please speak up if there is any disagreement. >>>>>>>>>>> >>>>>>>>>>> - Houston >>>>>>>>>>> >>>>>>>>>>> On Wed, Jul 22, 2020 at 4:40 PM Ishan Chattopadhyaya < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Absolutely, Ilan! Good idea. I initially hesitated in doing so >>>>>>>>>>>> because Andrzej had a workaround in mind for them, so I thought it >>>>>>>>>>>> would be >>>>>>>>>>>> better if he did this. But, it makes sense to inform them of the >>>>>>>>>>>> issue >>>>>>>>>>>> right away anyway. >>>>>>>>>>>> >>>>>>>>>>>> On Wed, 22 Jul, 2020, 11:42 pm Ilan Ginzburg, < >>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Shouldn't we add a note right away to 8.6 notifying of the >>>>>>>>>>>>> issue? >>>>>>>>>>>>> >>>>>>>>>>>>> Le mer. 22 juil. 2020 à 20:08, Atri Sharma <[email protected]> >>>>>>>>>>>>> a écrit : >>>>>>>>>>>>> >>>>>>>>>>>>>> +1, thanks Houston. >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Wed, Jul 22, 2020 at 10:51 PM Houston Putman < >>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > If we agree that this warrants a patch release, I volunteer >>>>>>>>>>>>>> to do the release. >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > I do think a patch release is reasonable even if users have >>>>>>>>>>>>>> to take an action when upgrading from 8.6.0. I imagine most >>>>>>>>>>>>>> users haven't >>>>>>>>>>>>>> upgraded to 8.6.0 yet, so if we make the patch now we will make >>>>>>>>>>>>>> life easier >>>>>>>>>>>>>> for everyone that upgrades between now and when 8.7 is released. >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > On Wed, Jul 22, 2020 at 12:50 PM Atri Sharma < >>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> >> Ignore this, I misread your email. >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> >> On Wed, Jul 22, 2020 at 9:11 PM Atri Sharma < >>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>> >> > >>>>>>>>>>>>>> >> > Should we not revert the change so that users upgrading >>>>>>>>>>>>>> from 8.6 to >>>>>>>>>>>>>> >> > 8.6.1 get the earlier default policy? >>>>>>>>>>>>>> >> > >>>>>>>>>>>>>> >> > On Wed, Jul 22, 2020 at 9:09 PM Houston Putman < >>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> >> > > +1 >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> >> > > Question about the change. Since this patch added a >>>>>>>>>>>>>> default autoscaling policy, if users upgrade to 8.6 and then >>>>>>>>>>>>>> 8.6.1, does >>>>>>>>>>>>>> the default autoscaling policy stay once they have upgraded? If >>>>>>>>>>>>>> so we >>>>>>>>>>>>>> probably want to include instructions in the release notes on >>>>>>>>>>>>>> how to fix >>>>>>>>>>>>>> this issue once upgrading. >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> >> > > - Houston >>>>>>>>>>>>>> >> > > >>>>>>>>>>>>>> >> > > On Wed, Jul 22, 2020 at 1:53 AM Ishan Chattopadhyaya < >>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>> >> > >> >>>>>>>>>>>>>> >> > >> Hi, >>>>>>>>>>>>>> >> > >> There was a performance regression identified in >>>>>>>>>>>>>> 8.6.0 release due to SOLR-12845. I think it is serious enough to >>>>>>>>>>>>>> warrant an >>>>>>>>>>>>>> immediate bug fix release. >>>>>>>>>>>>>> >> > >> >>>>>>>>>>>>>> >> > >> I propose a 8.6.1 release. Unfortunately, I'll be >>>>>>>>>>>>>> unable to volunteer for this release owning to some other >>>>>>>>>>>>>> commitments, >>>>>>>>>>>>>> however Andrzej mentioned in Slack that he might be able to >>>>>>>>>>>>>> volunteer for >>>>>>>>>>>>>> this post 27th. >>>>>>>>>>>>>> >> > >> >>>>>>>>>>>>>> >> > >> Are there any thoughts/concerns regarding this? >>>>>>>>>>>>>> >> > >> Regards, >>>>>>>>>>>>>> >> > >> Ishan >>>>>>>>>>>>>> >> > >>>>>>>>>>>>>> >> > -- >>>>>>>>>>>>>> >> > Regards, >>>>>>>>>>>>>> >> > >>>>>>>>>>>>>> >> > Atri >>>>>>>>>>>>>> >> > Apache Concerted >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> >> -- >>>>>>>>>>>>>> >> Regards, >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> >> Atri >>>>>>>>>>>>>> >> Apache Concerted >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>>>>>> >> To unsubscribe, e-mail: [email protected] >>>>>>>>>>>>>> >> For additional commands, e-mail: >>>>>>>>>>>>>> [email protected] >>>>>>>>>>>>>> >> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Atri >>>>>>>>>>>>>> Apache Concerted >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> --------------------------------------------------------------------- >>>>>>>>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> http://www.needhamsoftware.com (work) >>>>>>>>> http://www.the111shift.com (play) >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> http://www.needhamsoftware.com (work) >>>>>>> http://www.the111shift.com (play) >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> http://www.needhamsoftware.com (work) >>>>>> http://www.the111shift.com (play) >>>>>> >>>>> >>>>> >> >> -- >> http://www.needhamsoftware.com (work) >> http://www.the111shift.com (play) >> > >
