Wait. That maybe a different story. MRESOLVER-8. <https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commitdiff;h=5907bd44682925d8ea795fcb63c39d268157a632>
The changes to 'OptionalDependencySelector' made it behave the same way the 'ScopeDependencySelector' and other selectors are implemented. It's a bit sad there have not been any test cases for this. The test cases are testing the correct 1.0.x behaviour. That selector needed fixing to behave the same way as the other selectors. That's what you get when you cannot finish a task you started to work on a year ago. Hard to remember where to catch up after having left things WIP for a year. The plugin repository session in core may need to be reviewed and maybe need to be changed to no longer make use of that optional selector to get that IT pass. Maybe it's time to switch core to the resolver now and let Jenkins start doing it's job. I will look into that IT once the core is using the resolver snapshot finally. Makes no sense for everyone having to update the POMs locally. Am 10.12.2016 um 13:39 schrieb Hervé BOUTEMY: > I just tested the patch associated to MNG-6110 - Upgrade Aether to Maven > Resolver 1.2, and it caused one failure in ITs > testit(org.apache.maven.it.MavenITmng4721OptionalPluginDependencyTest) Time > elapsed: 0.185 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<1> but was:<0> > > Is it only me? > Fixing MNG-6110 is the first step before doing more changes, IMHO > > Regards, > > Hervé > > Le vendredi 9 décembre 2016, 11:56:01 CET Michael Osipov a écrit : >> Am 2016-12-06 um 22:46 schrieb Robert Scholte: >>> Hi, >>> >>> what is the status on this? Can we expect a release this year? >>> >>> I think the open issues are: >>> is maven-resolver ready to replace aether? >>> AFAIK some dependency management changes have been reverted, are all >>> others indeed bugfixes and safe to keep in this release? >> >> There is basically Resolver left, one good improvement is MNG-5896 along >> with the PR, but I cannot review it since I am not really familiar with >> the Resolver code. If someone is able to review MRESOLVER-7, please do >> and merge it. We could go on with Resolver 1.2 and continue with Maven >> 3.4 release. >> >> Michael >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
