If it's happening just due to the upgrade of the resolver, then it's a
resolver bugfix the IT hasn't been updated to reflect. I discussed this
issue with Jason in december last year when upgrading the resolver to
1.1 needed to be reverted.

<https://github.com/jvanzyl/aether-core/commit/da9708bf7321e25c2a74dddb893539f735135a6d>

Also part of:

<https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=1ee92862c67ec98564c4d8be1207355960f1dd5d>

This was lacking test cases badly. I am the author of the corresponding
test cases in the resolver. A few months later I had to correct those
tests to match the 1.0.x behaviour exactly.

<https://git-wip-us.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=5907bd44682925d8ea795fcb63c39d268157a632>

That IT would need to be updated to no longer run with Maven 3.4+ and a
new one needs to be created in parallel running with 3.4+, IMHO. The
bugfix also has an impact on how 'test' scope dependencies are resolved.
In short: If the scope of a transitive dependency is managed to 'test'
that dependency will no longer be resolved as the test scope is not
transitive.


Am 10.12.2016 um 13:39 schrieb Hervé BOUTEMY:
> I just tested the patch associated to MNG-6110 - Upgrade Aether to Maven 
> Resolver 1.2, and it caused one failure in ITs
> testit(org.apache.maven.it.MavenITmng4721OptionalPluginDependencyTest)  Time 
> elapsed: 0.185 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<1> but was:<0>
> 
> Is it only me?
> Fixing MNG-6110 is the first step before doing more changes, IMHO
> 
> Regards,
> 
> Hervé
> 
> Le vendredi 9 décembre 2016, 11:56:01 CET Michael Osipov a écrit :
>> Am 2016-12-06 um 22:46 schrieb Robert Scholte:
>>> Hi,
>>>
>>> what is the status on this? Can we expect a release this year?
>>>
>>> I think the open issues are:
>>> is maven-resolver ready to replace aether?
>>> AFAIK some dependency management changes have been reverted, are all
>>> others indeed bugfixes and safe to keep in this release?
>>
>> There is basically Resolver left, one good improvement is MNG-5896 along
>> with the PR, but I cannot review it since I am not really familiar with
>> the Resolver code. If someone is able to review MRESOLVER-7, please do
>> and merge it. We could go on with Resolver 1.2 and continue with Maven
>> 3.4 release.
>>
>> Michael
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to