Since git settings may influence line separators when cloning and Checkstyle seems to want read line separator to match System.lineSeparator, maybe the test need to take full control back (from git) over the two files in the test, to have a fully deterministic test input files.
- Eric L On Tue, May 14, 2019 at 4:18 PM Eric Lilja <mindcoo...@gmail.com> wrote: > Hi, I edited the wrong files before when I changed line breaks (edited > copies under target folder, silly me!). I changed the line separators to > Windows-style for the two files under MCHECKSTYLE-54 (Mcheckstyle54.java > and package.info) and the integration tests passes (expect for that other > failure, MCHECKSTYLE-70-multi-sourcefolder\pom.xml, when bumping Checkstyle > version to 8.20 I mentioned previously). > > Maybe your Windows node on Jenkins has git set-up to checkout files as > \r\n, and that's why it works there (assuming the job is indeed cloning). > > A question I now get in my mind how that Checkstyle feature should handle > the fact there is more than one type of line break (unfortunately) out > there, depending on OS... > > - Eric L > > > On Tue, May 14, 2019 at 3:08 PM Tibor Digana <tibordig...@apache.org> > wrote: > >> I wrote both files again, see the attachments (windows and Unix EOL). >> To be faster, I am running the command *mvn checkstyle:check* from the >> (IT target) path on my system >> c:\vcs\github\maven-checkstyle-plugin\target\it\MCHECKSTYLE-54\src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\ >> >> No idea why the linux EOL file fails on Windows system. >> >> Cheers >> Tibor >> >> >> On Tue, May 14, 2019 at 2:11 PM Enrico Olivelli <eolive...@gmail.com> >> wrote: >> >>> I will get a windows box and try to reproduce. >>> It is weird that on ASF Jenkins the build is passing even on windows >>> >>> Enrico >>> >>> ---------- Forwarded message --------- >>> Da: Enrico Olivelli <eolive...@gmail.com> >>> Date: mar 14 mag 2019, 13:58 >>> Subject: Re: [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0 >>> To: Maven Developers List <dev@maven.apache.org> >>> >>> >>> Eric and Tibor, >>> Thank you so much for your effort in testing Maven Checkstyle Plugin. >>> >>> This is the "official" VOTE thread, here we have to decide if the staged >>> artifacts are good to be released or not. >>> >>> Feel free to cast a -1 if you think that the staged artifacts are not >>> "stable" or there is any showstopper problem for the release. >>> >>> Let's move this discussion to a separate thread, something like >>> "Validation >>> failures in Windows over current checkstyle plugin master branch") >>> >>> Enrico >>> >>> >>> >>> >>> Il giorno mar 14 mag 2019 alle ore 13:51 Eric Lilja < >>> mindcoo...@gmail.com> >>> ha scritto: >>> >>> > Tried overriding line.separator when running using >>> -Dline.separator="\n", >>> > but then the builds fails (early) in maven-plugin-plugin: >>> > [ERROR] Failed to execute goal >>> > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor >>> > (default-descriptor) on project maven-checkstyle-plugin: Execution >>> > default-descriptor of goal >>> > org.apache.maven.plugins:maven-plugin-plugin:3.5:descriptor failed: >>> > Requested line separator is invalid. -> [Help 1] >>> > [ERROR] >>> > [ERROR] To see the full stack trace of the errors, re-run Maven with >>> the -e >>> > switch. >>> > [ERROR] Re-run Maven using the -X switch to enable full debug logging. >>> > [ERROR] >>> > [ERROR] For more information about the errors and possible solutions, >>> > please read the following articles: >>> > [ERROR] [Help 1] >>> > >>> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException >>> > >>> > Tried upgrading maven-plugin-plugin to 3.6.0 (lots of stuff >>> > upgradeable...), but same error >>> > >>> > I also happened to notice this (probably unrelated, but wanted to >>> bring it >>> > to attention anyway so it can be fixed) warning: >>> > [INFO] java-annotations mojo extractor found 4 mojo descriptors. >>> > [WARNING] >>> > >>> > Unexpected situation: destinationDirectory not defined in >>> > maven-plugin-help.properties during help mojo source generation but >>> > expected during XML descriptor generation. >>> > [WARNING] Please check helpmojo goal version used in previous build >>> phase. >>> > [WARNING] If you just upgraded to plugin-tools >= 3.2 you must run a >>> clean >>> > build at least once. >>> > [WARNING] Trying default location: target\generated-sources\plugin >>> > >>> > - Eric L >>> > >>> > On Tue, May 14, 2019 at 11:04 AM Eric Lilja <mindcoo...@gmail.com> >>> wrote: >>> > >>> > > I tried bumping checkstyle to 8.20, plus a few of the plexus >>> > dependencies, >>> > > but that just brought an additional failure... (to >>> > > MCHECKSTYLE-70-multi-sourcefolder\pom.xml) :-) >>> > > >>> > > I suppose the problem might be that the files has linux-style line >>> breaks >>> > > (this is desired for me, I don't want to convert to windows-style >>> line >>> > > breaks locally), but the test think I should have windows-style line >>> > > separators. It seems these files are generated by the tests because I >>> > tried >>> > > changing them to Windows style line breaks for re-running just to >>> see if >>> > > that would work, but those changes were overwritten) >>> > > >>> > > - Eric L >>> > > >>> > > On Tue, May 14, 2019 at 10:38 AM Eric Lilja <mindcoo...@gmail.com> >>> > wrote: >>> > > >>> > >> I also see a failure for MCHECKSTYLE-54 on Windows. (Sorry, I >>> didn't try >>> > >> the source zip, just cloned master) >>> > >> >>> > >> I tested on one of our corporate laptops: >>> > >> Windows 10 >>> > >> Cygwin 64-bit (I use it to clone the repo and use Maven) >>> > >> Maven 3.6.0 >>> > >> Java 8 update 202 >>> > >> >>> > >> The build log says: >>> > >> [INFO] There are 2 errors reported by Checkstyle 8.19 with >>> > sun_checks.xml >>> > >> ruleset. >>> > >> [ERROR] >>> > >> >>> > >>> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] >>> > >> (misc) NewlineAtEndOfFile: File does not end with a newline. >>> > >> [ERROR] >>> > >> >>> > >>> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] >>> > >> (misc) NewlineAtEndOfFile: File does not end with a newline. >>> > >> >>> > >> These two files end with unix-style line breaks (as expected with my >>> > >> setup). >>> > >> >>> > >> - Eric L >>> > >> >>> > >> >>> > >> On Tue, May 14, 2019 at 8:10 AM Enrico Olivelli < >>> eolive...@gmail.com> >>> > >> wrote: >>> > >> >>> > >>> Il lun 13 mag 2019, 23:48 Tibor Digana <tibordig...@apache.org> ha >>> > >>> scritto: >>> > >>> >>> > >>> > Robert, I did *not* use the source zip. >>> > >>> > >>> > >>> >>> > >>> IMHO we should vote on the staged zip >>> > >>> >>> > >>> >>> > >>> > git clone >>> > https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin >>> > >>> > Oracle jdk 1.8.0u212, Maven 3.3.9, Windows 10 >>> > >>> > >>> > >>> >>> > >>> This is what CI does and tests are passing. >>> > >>> >>> > >>> Do you have some global git configuration? >>> > >>> >>> > >>> Enrico >>> > >>> >>> > >>> > >>> > >>> > I see there is a new line, but the checkstyle does not care if >>> you >>> > put >>> > >>> one >>> > >>> > or two lines. >>> > >>> > No idea why. >>> > >>> > >>> > >>> > Even if you go to the target and run it from the folder >>> > >>> > c:\vcs\github\maven-checkstyle-plugin\target\it\MCHECKSTYLE-54\ >>> > >>> > it's the same as if you run the project root - mvn verify -P >>> > >>> > run-its,quality-checks >>> > >>> > >>> > >>> > >>> > >>> > *mvn -nsu checkstyle:check* >>> > >>> > >>> > >>> > [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check >>> > (default-cli) @ >>> > >>> > mcheckstyle-54 --- >>> > >>> > [INFO] There are 2 errors reported by Checkstyle 8.19 with >>> > >>> sun_checks.xml >>> > >>> > ruleset. >>> > >>> > [ERROR] >>> > >>> > >>> > >>> > >>> > >>> >>> > >>> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1] >>> > >>> > (misc) NewlineAtEndOfFile: File does not end with a newline. >>> > >>> > [ERROR] >>> > >>> > >>> > >>> > >>> > >>> >>> > >>> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1] >>> > >>> > (misc) NewlineAtEndOfFile: File does not end with a newline. >>> > >>> > [INFO] >>> > >>> > >>> > >>> >>> > >>> ------------------------------------------------------------------------ >>> > >>> > [INFO] BUILD FAILURE >>> > >>> > [INFO] >>> > >>> > >>> > >>> >>> > >>> ------------------------------------------------------------------------ >>> > >>> > [INFO] Total time: 3.450 s >>> > >>> > [INFO] Finished at: 2019-05-13T23:42:55+02:00 >>> > >>> > [INFO] Final Memory: 12M/193M >>> > >>> > [INFO] >>> > >>> > >>> > >>> >>> > >>> ------------------------------------------------------------------------ >>> > >>> > [ERROR] Failed to execute goal >>> > >>> > >>> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check >>> > >>> > (default-cli) on project mcheckstyle-54: You have 2 Checkstyle >>> > >>> violations. >>> > >>> > -> [Help 1] >>> > >>> > [ERROR] >>> > >>> > [ERROR] To see the full stack trace of the errors, re-run Maven >>> with >>> > >>> the -e >>> > >>> > switch. >>> > >>> > [ERROR] Re-run Maven using the -X switch to enable full debug >>> > logging. >>> > >>> > [ERROR] >>> > >>> > [ERROR] For more information about the errors and possible >>> solutions, >>> > >>> > please read the following articles: >>> > >>> > [ERROR] [Help 1] >>> > >>> > >>> > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException >>> > >>> > >>> > >>> > >>> > >>> > On Mon, May 13, 2019 at 10:29 PM Robert Scholte < >>> > rfscho...@apache.org> >>> > >>> > wrote: >>> > >>> > >>> > >>> > > This can happen when source-release.zip was created on a >>> different >>> > OS >>> > >>> > > compared to the verifying OS. >>> > >>> > > >>> > >>> > > With Git it will switch to the line endings of the operating >>> > system, >>> > >>> but >>> > >>> > > with a zip that's not possible. >>> > >>> > > >>> > >>> > > I'd say not blocking, but the IT needs to be fixed to handle >>> these >>> > >>> > > situations. >>> > >>> > > >>> > >>> > > Robert >>> > >>> > > >>> > >>> > > >>> > >>> > > On Mon, 13 May 2019 21:55:27 +0200, Enrico Olivelli < >>> > >>> eolive...@gmail.com >>> > >>> > > >>> > >>> > > >>> > >>> > > wrote: >>> > >>> > > >>> > >>> > > > Tibor >>> > >>> > > > It is strage all its are passing on CI. >>> > >>> > > > Are you sure you have correcly unpacked the package? >>> > >>> > > > >>> > >>> > > > >>> > >>> > > > Il lun 13 mag 2019, 21:23 Tibor Digana < >>> tibordig...@apache.org> >>> > ha >>> > >>> > > > scritto: >>> > >>> > > > >>> > >>> > > >> checked the sha512 of src zip, ok >>> > >>> > > >> checked the build, failed (mvn verify -P >>> run-its,quality-checks) >>> > >>> > > >> >>> > >>> > > > >>> > >>> > > > What is 'quality-checks' profile? I have never heard about it >>> > >>> > > > >>> > >>> > > > Enrico >>> > >>> > > > >>> > >>> > > > >>> > >>> > > >> [INFO] Building: MCHECKSTYLE-54\pom.xml >>> > >>> > > >> [INFO] MCHECKSTYLE-54\pom.xml >>> > >>> ........................... >>> > >>> > > >> FAILED >>> > >>> > > >> (5.3 s) >>> > >>> > > >> >>> > >>> > > >> *Mcheckstyle54.java:[1] (misc) NewlineAtEndOfFile: File >>> does not >>> > >>> end >>> > >>> > > >> with a >>> > >>> > > >> newline.* >>> > >>> > > >> >>> > >>> > > >> but I checkted this file and it ends with a new line. Is it >>> bug >>> > >>> in the >>> > >>> > > >> Checkstyle dependency? >>> > >>> > > >> >>> > >>> > > >> [INFO] BUILD FAILURE >>> > >>> > > >> [ERROR] Failed to execute goal >>> > >>> > > >> org.apache.maven.plugins:maven-pmd-plugin:3.8:cpd-check >>> > >>> (cpd-check) on >>> > >>> > > >> project maven-checkstyle-plugin: You have 1 CPD duplication. >>> > >>> > > >> >>> > >>> > > >> There are exactly the same methods. That's why CPD fails, >>> see >>> > >>> > > >> CheckstyleViolationCheckMojo L813 >>> > >>> > > >> AbstractCheckstyleReport L581 >>> > >>> > > >> >>> > >>> > > >> >>> > >>> > > >> >>> > >>> > > >> >>> > >>> > > >> >>> > >>> > > >> >>> > >>> > > >> >>> > >>> > > >> >>> > >>> > > >> >>> > >>> > > >> On Mon, May 13, 2019 at 11:52 AM Enrico Olivelli < >>> > >>> eolive...@gmail.com >>> > >>> > > >>> > >>> > > >> wrote: >>> > >>> > > >> >>> > >>> > > >> > Hi, >>> > >>> > > >> > >>> > >>> > > >> > We solved 13 issues: >>> > >>> > > >> > >>> > >>> > > >> > >>> > >>> > > >> >>> > >>> > > >>> > >>> > >>> > >>> >>> > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342397&styleName=Text&projectId=12317223 >>> > >>> > > >> > >>> > >>> > > >> > Please note that this version now only supports >>> CheckStyle 8+ >>> > >>> and >>> > >>> > > >> Java 8 >>> > >>> > > >> > (as required by latest Checkstyle) >>> > >>> > > >> > >>> > >>> > > >> > There are still a couple of issues left in JIRA: >>> > >>> > > >> > >>> > >>> > > >> > >>> > >>> > > >> >>> > >>> > > >>> > >>> > >>> > >>> >>> > >>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20XXXXXXXXXX%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC >>> > >>> > > >> > >>> > >>> > > >> > Staging repo: >>> > >>> > > >> > >>> > https://repository.apache.org/content/repositories/maven-1503/ >>> > >>> > > >> > >>> > >>> > > >> > >>> > >>> > > >> >>> > >>> > > >>> > >>> > >>> > >>> >>> > >>> https://repository.apache.org/content/repositories/maven-1503/org/apache/maven/plugins/maven-checkstyle-plugin/3.1.0/maven-checkstyle-plugin-3.1.0-source-release.zip >>> > >>> > > >> > >>> > >>> > > >> > Source release checksum(s): >>> > >>> > > >> > maven-checkstyle-plugin-3.1.0-source-release.zip sha512: >>> > >>> > > >> > >>> > >>> > > >> > >>> > >>> > > >> >>> > >>> > > >>> > >>> > >>> > >>> >>> > >>> eca46edb4d2f6cf2e250169ce5d5e510781b4bba116cc7b5655797cdb109ccdb0da883a1761347c6e2c77fe58395aff17e45c46d85a8a823340ae2b11c92852e >>> > >>> > > >> > >>> > >>> > > >> > Staging site: >>> > >>> > > >> > >>> > >>> > > >> >>> > >>> > > >>> > >>> > >>> > >>> >>> > >>> https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/ >>> > >>> > > >> > >>> > >>> > > >> > Guide to testing staged releases: >>> > >>> > > >> > >>> > >>> > > >> >>> > >>> > >>> > >>> >>> > >>> https://maven.apache.org/guides/development/guide-testing-releases.html >>> > >>> > > >> > >>> > >>> > > >> > Vote open for at least 72 hours. >>> > >>> > > >> > >>> > >>> > > >> > [ ] +1 >>> > >>> > > >> > [ ] +0 >>> > >>> > > >> > [ ] -1 >>> > >>> > > >> > >>> > >>> > > >> > >>> > >>> > > >> > Enrico Olivelli >>> > >>> > > >> > >>> > >>> > > >>> > >>> > > >>> > --------------------------------------------------------------------- >>> > >>> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> > >>> > > For additional commands, e-mail: dev-h...@maven.apache.org >>> > >>> > > >>> > >>> > > >>> > >>> > >>> > >>> >>> > >> >>> > >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > >
