----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review32961 -----------------------------------------------------------
Can we add a test for this please? src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62036> not yours but do you mind s/it's/its/ src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62035> s/slaveCompletedFrameworks/completedFrameworks/ src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62037> +1 s/slaveCompletedFrameworks/completedFrameworks/ src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62038> new line. src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62050> kill the log line or change it to VLOG. src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62049> Kill the log line or change it to VLOG. src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62040> s/id// src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62043> I'm not sure we want to LOG these. We don't even log the active frameworks/executors/tasks above. Maybe VLOG if you want use it for debugging. src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62042> s/MergeFrom/CopyFrom/ src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62044> ditto about logging. src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62046> I think you've brought this up before but did you figure out why a completed executor has terminated tasks? src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62045> ditto about logging. - Vinod Kone On Jan. 17, 2014, 12:24 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16724/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 12:24 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and > Vinod Kone. > > > Bugs: MESOS-767 > https://issues.apache.org/jira/browse/MESOS-767 > > > Repository: mesos-git > > > Description > ------- > > Added completed frameworks/tasks to slave re-registration. > Fixes MESOS-767. > > Additional issues discovered during investigation: > - MESOS-905: Remove Framework.id in favor of FrameworkInfo.id > - MESOS-906: Last task in Completed Framework never graduates from > terminatedTasks to completedTasks. > - Completed frameworks/executors/tasks are stored in circular buffers, > and these may overflow in different orders on different slaves. > BenH proposes an archive to replace these circular buffers. > > > Diffs > ----- > > src/master/master.hpp 95b9cec > src/master/master.cpp 38c5532 > src/messages/messages.proto 1f264d5 > src/slave/slave.cpp 396293b > > Diff: https://reviews.apache.org/r/16724/diff/ > > > Testing > ------- > > make check; manually failed-over a master, watched the slave reregister its > completed frameworks, web UI shows completed tasks and stdout/stderr. > > > Thanks, > > Adam B > >
