yes you are right, I made another round of adjustment. src NOTICE is empty bin NOTICE is filled with slf4j and protobuff -- Julien Vermillard :::: http://people.apache.org/~jvermillard/
On Sun, Jul 14, 2013 at 2:32 PM, Ashish <paliwalash...@gmail.com> wrote: > On Sun, Jul 14, 2013 at 5:41 PM, Ashish <paliwalash...@gmail.com> wrote: > >> We only need to add files to NOTICE if we bundle them right? >> http://www.apache.org/dev/licensing-howto.html#bundled-vs-non-bundled >> >> And we need two NOTICE files, one for src and one to bin like in MINA2 >> > > Correction: We have both in MINA3 as well :) > > >> >> For src, since we don't bundle anything, only simple Notice would do, for >> bin distro, we package protobuf & slf4j, along with Apache libs are the >> only things needed in notice. >> >> Sorry for this back and forth, but damn this legal stuff is confusing. >> >> >> On Sun, Jul 14, 2013 at 2:49 PM, Julien Vermillard >> <jvermill...@gmail.com>wrote: >> >>> Updated the files, if anybody could review, thanks :) >>> -- >>> Julien Vermillard :::: http://people.apache.org/~jvermillard/ >>> >>> >>> On Thu, Jul 11, 2013 at 11:57 AM, Emmanuel Lécharny <elecha...@gmail.com> >>> wrote: >>> > Le 7/11/13 10:43 AM, Julien Vermillard a écrit : >>> >> The question is : should we have NOTICE for test dependencies ? >>> > I do think so. We do have a NOTICE-bin.txt in MINA 2 which contains a >>> > reference to those libs (see below). >>> > >>> > Reading >>> > http://www.apache.org/dev/licensing-howto.html#overview-of-files, here >>> > are the few rules we should follow (as I interpret them) : >>> > >>> > - The file name should be NOTICE, not NOTICE.txt >>> > - every dependency we include in a package *must* be listed in the >>> > NOTICE file, including the transitive dependencies... (yeah, sorry...) >>> > - as we may distribute a package without tests, the associated NOTICE >>> > file should not contain the reference to JUNIT, etc. But if we >>> > distribute a package containing the tests -and we do- then we must add >>> > those dependencies into the NOTICE file. As a matter of fact, we do have >>> > 2 NOTICE files in MINA2, to cover those two cases (and we have a >>> > specific module to generate those two packages) >>> > >>> > Hope it helps... And sorry for the burdan ! >>> > >>> > >>> > >>> ---------------------------------------------------------------------------- >>> > Apache MINA >>> > Copyright 2007-2012 The Apache Software Foundation. >>> > >>> > This product includes software developed at >>> > The Apache Software Foundation (http://www.apache.org/). >>> > >>> > Please refer to each LICENSE.<component>.txt file for the >>> > license terms of the components that Apache MINA depends on. >>> > >>> > Message logging is provided by the SLF4J library package, >>> > which is open source software, written by Ceki Gülcü, and >>> > copyright by SLF4J.ORG and QOS.ch. The original software is >>> > available from >>> > >>> > http://www.slf4j.org/ >>> > >>> > Data compression support is provided by the JZLib library package, >>> > which is open source software, written by JCraft, and copyright >>> > by JCraft. The original software is available from >>> > >>> > http://www.jcraft.com/jzlib/ >>> > >>> > Spring framework is provided by the Spring framework library >>> > package, which is open source software, written by Rod Johnson >>> > et al, and copyright by Springframework.org. The original >>> > software is available from >>> > >>> > http://www.springframework.org/ >>> > >>> > OGNL is provided by the OGNL library package, which is open source >>> > software, written by Drew Davidson and Luke Blanshard. The original >>> > software is available from >>> > >>> > http://www.ognl.org/ >>> > >>> > >>> ---------------------------------------------------------------------------- >>> > >>> > >>> > >>> > >>> >> -- >>> >> Julien Vermillard :::: http://people.apache.org/~jvermillard/ >>> >> >>> >> >>> >> On Thu, Jul 11, 2013 at 12:59 AM, Emmanuel Lécharny < >>> elecha...@gmail.com> wrote: >>> >>> Le 7/10/13 9:03 PM, Julien Vermillard a écrit : >>> >>>> I heard (from Emmanuel I think) we don't need to put notice files for >>> >>>> apache products (thrift and log4j). >>> >>> Yes. The are apache projects, covered by the MINA NOTICE file. No need >>> >>> to add an extra file for each one of them, or to list them all. >>> >>>> So (if true) the only missing is netty used for benchmark which is >>> >>>> just tests no ? >>> >>> slf4j is not an Apache project, AFAICT. >>> >>> >>> >>> We are also using junit and mockito... >>> >>> >>> >>> >>> >>> -- >>> >>> Regards, >>> >>> Cordialement, >>> >>> Emmanuel Lécharny >>> >>> www.iktek.com >>> >>> >>> > >>> > >>> > -- >>> > Regards, >>> > Cordialement, >>> > Emmanuel Lécharny >>> > www.iktek.com >>> > >>> >> >> >> >> -- >> thanks >> ashish >> >> Blog: http://www.ashishpaliwal.com/blog >> My Photo Galleries: http://www.pbase.com/ashishpaliwal >> > > > > -- > thanks > ashish > > Blog: http://www.ashishpaliwal.com/blog > My Photo Galleries: http://www.pbase.com/ashishpaliwal
