On 24.01.22 11:31, Neil C Smith wrote:
On Sun, 23 Jan 2022 at 11:54, Michael Bien <[email protected]> wrote:
i don't think it matters at all what it fixes because the latest update
release is the best available version of that branch.
I've been stung by too many regressions in bug fix updates to believe
that updating dependencies is entirely risk free! Including in
nb-javac incidentally, although that should be far less likely to
happen now I hope.
So, to me it comes down to weighing that risk and work involved
against the fixes and impact on NetBeans itself. If there was no
benefit at all (which is not what I'm saying), why do it?
the nb-javac dependency is rather special since all java features are
built around it + it is a compiler (!).
Having an editor using a different compiler (or version) than your build
is not a optimal situation. NB is getting closer and closer to be able
to use the JDK's compiler (thats why i am also hoping that NB can one
day turn nb-javac off if the JDK is recent - but that is a different
topic, I haven't tested it if its still possible with NB 13 after the
changes we made)
regarding regressions:
my point exactly. That is why i don't want to add it now so late in the
RC phase (but if anyone wants to do it, feel free to do so, diff below).
That is also why i wrote the mail. Dep updates this significant should
be made before rcs start. I did not ask for someone else to update it! I
pointed out that there will be a javac update release during the rc
phase _every_ time if we don't change anything.
NB 14 will have it worse since experience shows that there are
significantly more changes between GA and update 1 which follows one
month after it. Update 2 of JDK 17 is the best case scenario changeset wise.
do we want to:
- adjust the release dates a little so that we can add the latest javac
before rc in future
- or go through the trouble of last minute inclusions, risk assessments
and all the unfun parts of sw dev and try to include it anyway during rc
phase
- or live with the fact that NB will lack one update release behind
every release
diff --git
a/make/langtools/netbeans/nb-javac/nbproject/project.properties
b/make/langtools/netbeans/nb-javac/nbproject/project.properties
index d7aef9a..b501da6 100644
--- a/make/langtools/netbeans/nb-javac/nbproject/project.properties
+++ b/make/langtools/netbeans/nb-javac/nbproject/project.properties
@@ -1,6 +1,5 @@
-
-jdk.git.url=https://github.com/openjdk/jdk
-jdk.git.commit=jdk-18+25
+jdk.git.url=https://github.com/openjdk/jdk17u/
+jdk.git.commit=jdk-17.0.2+8
nb-javac-ver=${jdk.git.commit}
the PR was not the problem since nb-javac is already ready for JDK 18
thanks to Jaroslav's heroic efforts.
-mbien
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
