+1 (binding) Voting early to also respond to Matthias' point. I intend to keep the vote open.
Without turning this too much into a discussion thread, both things are ugly but intended at the moment. They need addressing, along with a few other things, in the NB21 timeframe. I would have more of an issue with the license and notice if these were public facing binaries, rather than internally facing fragments of the build (which shouldn't be on OSUOSL, and the existing file doesn't have them either). They cannot be used in any circumstance other than where people have those files already. If we need to discuss further, let's move to the existing discussion thread at https://lists.apache.org/thread/08hsrfgn6klcf9bm8t96h6pv0zrysfjm Thanks, Neil On Tue, 3 Oct 2023 at 20:43, Matthias Bläsing <mblaes...@doppel-helix.eu.invalid> wrote: > > -1 (binding) > > I'm sorry, but the binary artifact is missing LICENSE and NOTICE files. > I would expect them to be located beside the BUILDINFO.txt file. > > I have a minimal nitpick about the source zip. It seems overly > complicated. It took me a some time to realise, that only the > profiler/lib.profiler/native/ is relevant and can be diffed against the > corresponding repository dir. The rest of the file is a placeholder > directory structure, which looks like it could be replace by "mkdir -p > $DEST" in the build scripts. > > Greetings > > Matthias > > > > Am Dienstag, dem 03.10.2023 um 10:51 +0100 schrieb Neil C Smith: > > This is a vote on the lib.profiler native binaries. As the binary > > artefacts are consumed by the IDE build, we need to release them > > separately when they need updating. > > > > The main purpose of this version is to allow us to ship Apple Silicon > > support for the profiler in NetBeans 20. > > > > Primary voting artefact : > > https://dist.apache.org/repos/dist/dev/netbeans/native/netbeans-profiler/1-r2196e46/profiler-external-sources-1-r2196e46.zip > > SHA : > > 6f41f0bed161f2e718bf1f0497e631446bf363d7b6affd4ab021e12a5b94c88b8896da8d6c7ec6bd5f411b64770276379c394041f120fe62edd52ed72e2ba3b0 > > > > Alongside the source artefact are the zipped binary artefacts : > > > > https://dist.apache.org/repos/dist/dev/netbeans/native/netbeans-profiler/1-r2196e46/ > > > > Once released the binaries will be consumed by the IDE. A draft PR, > > including dev build, using the staged artefacts is at > > https://github.com/apache/netbeans/pull/6502 > > > > The source and binary artefacts were created in GitHub actions run > > https://github.com/apache/netbeans/actions/runs/6351527745 using the > > workflow at > > https://github.com/apache/netbeans/actions/runs/6351527745/workflow > > > > The workflow extracts the necessary parts of the NetBeans repository > > into the source bundle, then passes the source bundle to the various > > different OS runners to build the binaries. See the workflow file for > > how to build from source on each OS. > > > > This vote is going to be open at least 72 hours. Vote with +1, 0, and > > -1 as usual. Please mark your vote with (binding) if you're an Apache > > NetBeans PMC member. > > > > Many thanks everyone, > > > > Best wishes, > > > > Neil > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > > For additional commands, e-mail: dev-h...@netbeans.apache.org > > > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
