On Jan 26, 2007, at 11:15 AM, Jonathon -- Improov wrote:
A common cry on JIRA: "Will somebody test this patch please? Gonna commit inside of 48 hours."
Hopefully in the future we'll have people testing things before a committer looks at it. On a similar note, hopefully you won't see any more messages like the above. It's a bad practice that is hopefully now corrected among the committers. In short a committer should not commit anything if they don't know what the impact of it is and hasn't at least done a sanity check and code review on it.
Of course, even if a committer does a thorough review it is possible to miss stuff, things are just complicated that way and certain parts of OFBiz are still very poorly implemented and brittle, so any review and testing of patches or the project in general is always helpful! This is especially true for people testing it against real-world requirements and business scenarios because they'll can't things that no automated test can, and because it will bring up issues that others may not have even realized were issues.
-David
smime.p7s
Description: S/MIME cryptographic signature
