> Adrian Crum wrote: > > ... > > I think it would be best if we could hold off on committing OFBIZ-754 > > and OFBIZ-671 for a little while longer. I have been refactoring the > > Party Manager component as a test bed for the UI refactoring initiative, > > and even though that work is nearly done, I'm still finding ways to > > improve the main style sheet and widgets. Bottom line is, they aren't > > fully cooked. > > > > I've applied the new styles: > > https://issues.apache.org/jira/browse/OFBIZ-754 > > the form widget refactoring: > > https://issues.apache.org/jira/browse/OFBIZ-671 > > and the party example: > > https://issues.apache.org/jira/browse/OFBIZ-763 > > and they all seem pretty good to me. > I'd suggest to commit everything to svn and then force the community to > test it ;-) > In this way we will get more feedback and will speed up the refinement > of this effort. > I can commit the work if there are no objections, but before I go on I'd > love to get committers' feedback, especially on OFBIZ-671.
+1, Commit Then Review is ok for me in such a case, else it will take longer... Always possible to revert anyway... Jacques > Jacopo > > > > From my perspective, the ideal scenario would be to have another > > contributor take on one of the other components and start refactoring it > > using the new style sheet and widgets. They can see if there is anything > > lacking in the new versions and improve upon what I've done so far (if > > necessary). When they give a nod of approval, then we can get the new > > style sheet and widgets committed to the project. > > > > If anyone has a better plan, please suggest it. > > > > -Adrian > > > > >
