I don't think we actually have an established policy for this. I guess as with
anything if there are concerns with a commit then it is totally appropriate to
bring them up and discuss them after the fact, and there is nothing stopping a
change in direction.
-David
Scott Gray wrote:
Hi David
I guess my main concern was that this wasn't discussed beforehand and it was
also committed by someone without framework privileges, I don't have any
objections to the commit itself but I just worry about the impression it
gives to current and potential committers about what is acceptable practice.
Regards
Scott
On 30/07/07, David E Jones <[EMAIL PROTECTED]> wrote:
This is a good question... Right now these are mainly used for special
pages and we don't really have framework use of these yet, so I'd say at
this point we'll just have to see how things shake out!
The two main contenders in our discussions about this were Prototype and
DOJO... so hopefully we won't have too much others coming in that will need
to be shaken out. If necessary we'll trim one of these, but we might even
want to keep both... I don't know though...
Does anyone else have any thoughts on the best thing to do here?
-David
Scott Gray wrote:
I thought we were using dojo after much discussion a couple of months
back?
Are we intending to use multiple libraries?
Regards
Scott
On 30/07/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: apatel
Date: Sun Jul 29 20:45:00 2007
New Revision: 560854
URL: http://svn.apache.org/viewvc?view=rev&rev=560854
Log:
Prototype and Scriptaculous javascript libs.
Added:
ofbiz/trunk/framework/images/webapp/images/prototypejs/
ofbiz/trunk/framework/images/webapp/images/prototypejs/builder.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/controls.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/dragdrop.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/effects.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/prototype.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/scriptaculous.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/slider.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/sound.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/unittest.js
ofbiz/trunk/framework/images/webapp/images/prototypejs/validation.js
