Hi Ratnesh,
About 1 and 2, in such cases I always try to find the roots.
1. It's https://issues.apache.org/jira/browse/OFBIZ-290 look for
webSiteId,OrderEntry
2. http://svn.apache.org/viewvc?view=revision&revision=1128984
Unfortunately seems that this not add much. I also wonder if the data in
OrderTestData.xml are ever used (else tests would fail, right?)
Anyway, I agree with your conclusion.
My 2cts
Jacques
Le 26/08/2017 à 14:48, Ratnesh Upadhyay a écrit :
Devs,
I've noticed few things that needs to be discussed :
1. We have few order in DemoOrderTestData.xml and OrderTestData.xml that
are having webSiteId="OrderEntry" but we don't have any record in WebSite
entity for "OrderEntry" webSiteId.
2. We have "setCustRequestStatus" and "setCustRequestStatus" ecas where we
are having following condition :
<condition field-name="webSiteId" operator="equals" value="OrderEntry"/>
Although we don't have this webSite record in entity then these ecas are no
more of use as system never meet this condition.
3. There is no "webSiteId" is being set for orders placed from ordermgr
application, so IMO we should setup webSiteId parameter in servletConetext
of ordermgr app to get it setup. I can see its usage to get the information
of orders placed from store front as well as from backend application.
To apply FK constraint either we have to add record in WebSite entity or
remove the references of "OrderEntry" webSiteId from order demo data. Also
please let me know your thoughts to set webSiteId for backend apps.
IMO, we should add record in WebSite entity for "OrderEntry".
Thanks!!
Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com
On Sat, Aug 26, 2017 at 1:08 PM, Ratnesh Upadhyay <
upadhyay.ratn...@gmail.com> wrote:
Thanks everyone for your inputs.
Here is the jira ticket : https://issues.apache.org/jira/browse/OFBIZ-9647
Regards,
Ratnesh Upadhyay
HotWax System | www.hotwaxsystems.com
On Sat, Aug 26, 2017 at 11:54 AM, Arun Patidar <
arun.pati...@hotwaxsystems.com> wrote:
Nice catch Ratnesh, we can take this as an improvement.
--
Thanks & Regards
---
Arun Patidar
Manager, Enterprise Software Development
HotWax Systems Pvt Ltd.www.hotwaxsystems.com
On Thu, Aug 24, 2017 at 7:50 PM, Ratnesh Upadhyay <
upadhyay.ratn...@gmail.com> wrote:
Hello Devs,
I just walked though from OrderHeader entity and noticed that we have
webSiteId field there but we don't have any FK constraint for it from
OrderHeader.webSiteId to WebSite.webSiteId. I was expecting that it
must be
there.
So just curious to know why it was not there, was it intentional? Please
let me know if anyone have any information on it else I would provide a
patch to get it fixed.
Thanks!!
Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com
