Dear Swapnil, Got the point, thanks for the details and clarifying it. As per current flow, system creates exchange/replacement orders. And in exchange/replacement order it applies promotion from promo engine as new exchange/replacement order created. For the refund/adjustment net amount calculation it uses the original order calculation. For new order it uses promo engine, so return amount calculation and new order amount calculation treated differently.
I would say it is very good concern and should be taken care (test and then fix if any issue found) of handling returns against each order. And I think we can separate that work from weather the promo applying automatically or manually on original order. Also return policy differ business to business and promo apply accordingly on return exchange order. Best Regards, -- *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax Systems <http://www.hotwaxsystems.com/> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore, M.P 452010 Linkedin: *Rishi Solanki* <https://www.linkedin.com/in/rishi-solanki-62271b7/> Direct: +91-9893287847 On Thu, May 2, 2019 at 12:14 AM Swapnil Shah <swapnil.s...@hotwaxsystems.com> wrote: > Actually my (and possibly Pierre's) concern was bit different. Many a times > system needs to allow exchanging the originally ordered item with a > different item. In such cases if it starts auto-inheriting the adjustments > then customer can start gaming the system by purchasing the discounted > items > and exchanging it with full priced or lesser discounted items. > > For example, customer originally purchases $100 item at 20% discount > (doesn't matter whether default or overridden from eligible set of active > promotion). Now returns it and get it exchanged with another $100 item > which > doesn't have any active applicable promotions and is currently being sold > at > fully price. If system always inherit and auto-apply the adjustments from > originally ordered item then my store would end up actually selling a > non-discounted item at 20% discount. > > A possible solution could be that while exchanging the item, system can > check whether the exchanged item is eligible for same promotion as that of > returned item or not. If yes inherit and apply the same adjustments else > not. Here again authorized user with desired permissions can be allow to > manually override it later if required. > > Thanks, > Swapnil > > -----Original Message----- > From: Rishi Solanki <rishisolan...@gmail.com> > Sent: Wednesday, May 01, 2019 6:49 PM > To: dev@ofbiz.apache.org > Subject: Re: Applicable Promo Recommendations > > Some addition details I could think of, thanks for raising this point. > One use case to be consider as per Swapnil comment, but it is not > implemented in OFBiz. If business take returns of Non Order Items (Items > purchased but Order does not exists in the system). In this case depending > upon the business requirement system may need to identify the applicable > promotion on return. For now it is handle with manual adjustment in current > flow. > Right now non order item return not supported in current process flow. But > we should surely take care of this corner case, when we think of > implementing non order item return. > > Best Regards, > -- > *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax > Systems > <http://www.hotwaxsystems.com/> Plot no. 80, Scheme no. 78 Part 2, Near > Brilliant Convention Center, Indore, M.P 452010 > Linkedin: *Rishi Solanki* > <https://www.linkedin.com/in/rishi-solanki-62271b7/> > Direct: +91-9893287847 > > > On Wed, May 1, 2019 at 6:13 PM Rishi Solanki <rishisolan...@gmail.com> > wrote: > > > Dear Swapnil/Pierre, > > Thanks for more thoughts on the subject. The return > > (refund/replacement/exchange) always use original order adjustments > > for return. No promo engine or price rule engine run in that case. > > This is because return adjustments always depends on the order > > adjustment. The only flexibility OFBiz workflow provides to add manual > > adjustments in case of conflict. > > > > IMO we are good to go with proposal. As return never use the promo > > engine to apply promo and it is only work for order as per the current > > flow. > > > > Best Regards, > > -- > > *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax > > Systems <http://www.hotwaxsystems.com/> Plot no. 80, Scheme no. 78 > > Part 2, Near Brilliant Convention Center, Indore, M.P 452010 > > Linkedin: *Rishi Solanki* > > <https://www.linkedin.com/in/rishi-solanki-62271b7/> > > Direct: +91-9893287847 > > > > > > On Wed, May 1, 2019 at 1:42 PM Pierre Smits <pierresm...@apache.org> > > wrote: > > > >> Thanks Swapnil, for your posting as it triggered a thought about > >> gaming the promotions by e-commerce customer. > >> > >> The though was: is this not opening up the whole for nefarious > >> e-commerce customers to game the functionalities in their favour (and > >> to the disadvantage of the adopter and its other customers) regarding > >> ordering and returning goods as such? > >> > >> I don't have that full picture yet, so it may be a non-issue. But on > >> the other hand.... better safe than sorry, right? > >> > >> Best regards, > >> > >> Pierre Smits > >> > >> *Apache Trafodion <https://trafodion.apache.org>, Vice President* > >> *Apache Directory <https://directory.apache.org>, PMC Member* Apache > >> Incubator <https://incubator.apache.org>, committer *Apache OFBiz > >> <https://ofbiz.apache.org>, contributor (without > >> privileges) > >> since 2008* > >> Apache Steve <https://steve.apache.org>, committer > >> > >> > >> On Wed, May 1, 2019 at 9:49 AM Swapnil Shah < > >> swapnil.s...@hotwaxsystems.com> > >> wrote: > >> > >> > I am not sure if it might require an add-on handling or not but can > >> someone > >> > please test or make sure that exchange orders against the > >> > originally ordered style/assortment inherit the order adjustments > >> > from original order > >> (instead > >> > of auto applying the default promo again) or at least provide the > >> > same manual overriding options so as to make sure that exchange > >> > invoices are > >> in > >> > coherence with the original order invoice. > >> > > >> > Thanks, > >> > Swapnil > >> > > >> > -----Original Message----- > >> > From: Rishi Solanki <rishisolan...@gmail.com> > >> > Sent: Sunday, April 28, 2019 4:09 AM > >> > To: dev@ofbiz.apache.org > >> > Subject: Applicable Promo Recommendations > >> > > >> > Devs, > >> > I would like to propose the user selection ability for promotion. > >> > That means user can select her own choice of promotion from the > >> > list of promotion applicable to current cart. Right now promotion > >> > engine based on > >> algorithm > >> > implemented decide which promotion will be apply to cart from the > >> > list > >> of > >> > promotion. For example, if promotion engine find 3 promotion > >> > applicable > >> for > >> > the current cart then based on algorithm implemented it apply the > >> maximum > >> > amount value promotion to the cart. > >> > > >> > Coming back to proposal with some use cases; > >> > > >> > Use Case 1: Promotion engine find three promotions applicable to > >> > cart or item as P1, P2 and P3. And as per algorithm promo engine > >> > decide to apply P1. > >> > Now if user want to go with P2 or P3 then she can do that. > >> > > >> > Use Case 2: In #1 user can also choose to not take any promotion, > >> > remove the > >> > P1 and submit the order without promotion. > >> > > >> > Use Case 3: Item1 and item2 will have two promotions common as P1 > >> > and > >> P2. > >> > Now user can opt which promotion should applicable to which item. > >> > That means user can apply P1 or P2 on item1 or item2 based on her > >> > preference. > >> > > >> > Use Case 4: In #3 if user wants then she can opt to select > >> > promotion for one item and can remove promo from other. > >> > > >> > > >> > Looking forward for valuable feedback on proposal and suggestion on > >> design > >> > from community. Also please feel free to ask for more details on > >> > each > >> use > >> > case or on proposal itself. > >> > > >> > > >> > Thanks! > >> > > >> > Best Regards, > >> > -- > >> > *Rishi Solanki* | Sr Manager, Enterprise Software Development > >> > HotWax Systems <http://www.hotwaxsystems.com/> Plot no. 80, Scheme > >> > no. 78 Part 2, Near Brilliant Convention Center, Indore, M.P 452010 > >> > Linkedin: *Rishi Solanki* > >> > <https://www.linkedin.com/in/rishi-solanki-62271b7/> > >> > Direct: +91-9893287847 > >> > > >> > > >
