answer inline Le 27/11/2019 à 19:02, Mathieu Lirzin a écrit : > Hello Olivier, > > Olivier Heintz <holiv...@apache.org> writes: > >> As explained in a previous mail, we (me and others co-worker in a company I >> am working for) are working on a POC for using Vue.js as GUI generated >> from the current screens/forms/menu xml ofbiz files. >> The customer goals is to be able to migrate a lot of existing Portal / >> portlet developed with ofbiz R13.07 on trunk and on a modern GUI. >> >> The main customer specification / requirement are, for the first step of >> migration >> 1. minimum of modifications on xml file, to have the easier and quicker >> migration >> 2. same GUI rules, to facilitate user acceptance >> 3. new GUI for a component should be working with classic GUI for other >> components >> Enhancement can be possible but will be applied in a second step with >> productOwner check and validation. >> >> Current POC status is : done with example for some screen / field /menu, >> waiting user testing feed back before starting partymgr migration. >> >> Our demo platform is >> https://ofbiz-selenium.ofbizextra.org/examplefjs/control/main with admin / >> ofbiz >> >> the chosen architecture is, >> 1. a new ScreenViewHandler which >> - use new renderer for screen / form /menu >> - to return a json with 2 map >> * ViewScreen with detail about presentation (similar to xml tag and >> properies) >> * ViewEntity with data to populate ui generated (extract from screen/forms >> data) > > Providing a JSON view handler is very interesting because it enables any kind > of Javascript front-end to consume data rendered by existing OFBiz screens > (with data preparation, etc). This contributes to the current effort of > implementing a REST API by enabling consumers to have a JSON representation of > the retrieved data which is convenient to manipulate from Javascript [1]. > > Would you be interested in spending some time integrating this view handler > inside the framework? of course, I can created a Jira with the java and update them when there are remarks or discussions > > The requirements for such task would be to lint the code, write some > integration tests, some javadoc, some comments explaining the non-obvious > parts of the implementation, ... well a non-negligeable amount of work which > is important for maintainability reasons. the amount of work is not the main problem ;-) My knowledge and skill will be more difficult to solve, I am a business/functional consultant and so a java copy/paste developer (or a "java simple/procedural" business process developer) not a java framework developer. In the team I'm working, other Co-workers are front-end developer or profile similar than me.
So, 1) javadoc no problem and documentation in adoc format no problem too 2) cleaning code, and applying best practice, no problem if reviewer can give me some link or example 3) integration test, when I read the ModelFormFieldTest.java I don't understand what it does and the java ... so I will need some help for this sub-task > > For example one requirement would be to use ‘org.apache.ofbiz.base.lang.JSON’ > instead of ‘org.json.simple.JSONObject’ in order to avoid depending on > multiple JSON libraries. Clear, I have done it. Thank you for the remark > > Moreover on the features side, it might be interesting to make the > presentation related stuff optional for consumers only interested by the data > aspect of the data. > > What do you think? Yes it's in the POC plan, but currently we are more focus on having a clear user demonstration in a business environment. This month a large part of Party component have been done and we are working on solving all bugs/"form xml functionality not yet implemented" Hoping to have a usable demo next week. (https://ofbiz-selenium.ofbizextra.org/partymgrfjs/control/showPortalPage?portalPageId=PartyMgmtFrontJs) Next week I will do a mail with the detail of what is usable and which next step are possible If you or community think that implemented this option is a priority, we will do it, I think it will not too difficult. > > [1] https://issues.apache.org/jira/browse/OFBIZ-4274 Yes I know it, but very too technical for me, too many word I don't understand ;-) >
