> On Dec. 5, 2012, 6:12 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java, > > line 211 > > <https://reviews.apache.org/r/8346/diff/1/?file=233983#file233983line211> > > > > The relationship between message handler and receiver is one to many, > > which will cause the messages from all consumers(receivers) to be handled > > by only one handler. Shouldn't it be 1-1? > > Mona Chitnis wrote: > You are probably right. Better not rely on the JMS Receiver's > synchronization when multiple messages are to be handled simultaneously.
We have to rely on JMS Receiver's synchronization. However when all the synchronized receivers call the message handler, the handler will break if its not 1-1 relationship - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8346/#review14053 ----------------------------------------------------------- On Dec. 5, 2012, 12:22 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8346/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2012, 12:22 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1108 > > WIP patch *on TOP* of OOZIE-1111 - the HCat URI changes. This patch also > fixes a lot of affected test cases > > > This addresses bug OOZIE-1108. > https://issues.apache.org/jira/browse/OOZIE-1108 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestMessageReceiver.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1416645 > branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java > 1416645 > > Diff: https://reviews.apache.org/r/8346/diff/ > > > Testing > ------- > > > Thanks, > > Mona Chitnis > >
