----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8346/#review14510 -----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8346/#comment30901> We are not removing the server end point from the connSessionMap in any place. So it will not enter this else block and establish a new connection. IMO, we should be doing the reliability of JMS connection in separate JIRA bcoz that will involve multiple things like closing old connectiions, updating data structures, retrying muliple times to establish new connections, etc. branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8346/#comment30902> why is a function being called to access variable of the same class? - Virag Kothari On Dec. 14, 2012, 3:15 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8346/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2012, 3:15 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1108 > > patch *on TOP* of OOZIE-1111 - the HCat URI changes. This patch also fixes a > lot of affected test cases > > > This addresses bug OOZIE-1108. > https://issues.apache.org/jira/browse/OOZIE-1108 > > > Diffs > ----- > > branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java > 1421635 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1421635 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1421635 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1421635 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1421635 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1421635 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java > 1421635 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java > 1421635 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestMessageReceiver.java > 1421635 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1421635 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1421635 > branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java > 1421635 > > Diff: https://reviews.apache.org/r/8346/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Mona Chitnis > >
