----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8346/#review14098 -----------------------------------------------------------
Comments only for the receiver-handler 1-1 relationship code branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java <https://reviews.apache.org/r/8346/#comment30165> The earlier mapping in the 1st diff seemed fine to me. Plz look at other comments branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8346/#comment30160> As this a generic JMS class, different consumers should be allowed to create from one session. Its better to leave this method unchanged. I actually would prefer that you keep things similar as in 1st diff with the only change of having 1-1 relationship between MessageReceiver (listener) and MessageHandler. I have mentioned this change as a comment for _registerMessageReciever() branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/8346/#comment30162> registerMessageReceiver(String topic){ MessageReceiver recvr = Services.get().get(JMSAccessorService.class).getTopicReceiver(topic); if (recvr==null){ recvr = new MessageReceiver(new MessageHandler()); log.debug("Registering to listen on topic :" + topic); recvr.registerTopic(topic); } if (recv!=null{ // do nothing } } Wont the above code along with your 1st diff solve the problem of 1-1 relation between receiver and handler? branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/8346/#comment30163> doing this will remove the existing handler for the receiver and set a new one. - Virag Kothari On Dec. 6, 2012, 1:04 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8346/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 1:04 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1108 > > patch *on TOP* of OOZIE-1111 - the HCat URI changes. This patch also fixes a > lot of affected test cases > > > This addresses bug OOZIE-1108. > https://issues.apache.org/jira/browse/OOZIE-1108 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestMessageReceiver.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1416645 > branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java > 1416645 > > Diff: https://reviews.apache.org/r/8346/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Mona Chitnis > >
