----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8346/#review14341 -----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8346/#comment30537> As the method signature has MessageReceiver, means the connection for endpoint already exists and session, receiver are also created. If a new connection is created at this point, the receiver will still belong to the old connection which is somehow null. So, probably the null check should be done beforehand. It can be done before the method is called: if (consumer!=null){ consumer.setMessageListener(this); LOG.info(" Listener registered for end point ." + endPoint + " topic :" + topicName); jas.addTopicReceiver(this, endPoint, topicName); } } branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java <https://reviews.apache.org/r/8346/#comment30538> It's not private but package-private :). Its accessible to classes of the same package branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/8346/#comment30540> Recovery service runs at a fixed interval in a single thread and there is no danger of the list growing quickly. Here, its a different case. So I think its better to queue it serially instead of using composite callable. - Virag Kothari On Dec. 11, 2012, 4:29 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8346/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 4:29 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1108 > > patch *on TOP* of OOZIE-1111 - the HCat URI changes. This patch also fixes a > lot of affected test cases > > > This addresses bug OOZIE-1108. > https://issues.apache.org/jira/browse/OOZIE-1108 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestMessageReceiver.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1416645 > branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java > 1416645 > > Diff: https://reviews.apache.org/r/8346/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Mona Chitnis > >
