> On Dec. 11, 2012, 6:46 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java, > > line 302 > > <https://reviews.apache.org/r/8346/diff/4/?file=236766#file236766line302> > > > > A new connection should not be created for a new topic. Just updating > > the map with the topic name and receiver seems to be enough in this method.
If you see a couple of lines above, this is done only is connection to that particular endpoint does not exist beforehand. Endpoint is determined from the partition and passed to this method > On Dec. 11, 2012, 6:46 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java, > > line 336 > > <https://reviews.apache.org/r/8346/diff/4/?file=236766#file236766line336> > > > > private I think it is private by default. but doesnt hurt to add it > On Dec. 11, 2012, 6:46 p.m., Virag Kothari wrote: > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java, > > line 548 > > <https://reviews.apache.org/r/8346/diff/4/?file=236767#file236767line548> > > > > the list should be synchronized. Also the list may grow very quickly. > > So, instead of queueing a list of callables, is it not better to queue > > single command? In that way, the list will not be required Following the same pattern as in RecoveryService, where a list is used. In turn, the CallableQueueService takes this list of callables and makes into a CompositeCallable (see method queueSerial). - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8346/#review14298 ----------------------------------------------------------- On Dec. 11, 2012, 4:29 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8346/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 4:29 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1108 > > patch *on TOP* of OOZIE-1111 - the HCat URI changes. This patch also fixes a > lot of affected test cases > > > This addresses bug OOZIE-1108. > https://issues.apache.org/jira/browse/OOZIE-1108 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1416645 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestMessageReceiver.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1416645 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1416645 > branches/hcat-intre/core/src/test/java/org/apache/oozie/test/XTestCase.java > 1416645 > > Diff: https://reviews.apache.org/r/8346/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Mona Chitnis > >
