Caolan McNamara wrote:
On Fri, 2008-05-09 at 16:47 +0200, Eike Rathke wrote:
while ScCompressedArray::GetPrevValue() is currently
unused it is the counterpart of GetNextValue() and IMHO should be kept
for completeness of implementation.
Perhaps #ifdef FUTURE around it, or else I can add such things to the
whitelist if that's undesirable.
Good old "opt-in vs. opt-out" choice. I'd prefer to leave all methods in
the header files, commented out and marked somehow, unless someone has
(manually) determined that they really shouldn't be there.
Otherwise, inevitably, it will cause problems much later, where you look
at a class and ask yourself, "how is that supposed to work, I can (for
example) add an entry but not remove it".
I know these marks are ugly and tend to stay there forever (example:
CHINA001), but it's still better than always having to dig through the
CVS log to see if the class you're looking at is still the class as it
was intended to be.
Niklas
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
