And while you are at it also replace the countless methods that
still use sal_uInt16 instead of int as return value... goodbye
Win3.1! ;-)

Replace those methods with what? ;)

With their int equivalents. E.g.
   svx/inc/svx/svdpage.hxx:  sal_uInt16 GetPageNum() const;
could be replaced by
   svx/inc/svx/svdpage.hxx:  int GetPageNum() const;

Isnt that kinda contradicting the original post by thb?
Shouldnt that be:

sal_Int32 GetPageNum() const;

/me wonders.

That was my point. The rule that got us the hardcoded WIN16-style code then is not IMHO is not a good guide for the future. If the timeless native types had been used it would have grown with the platform.

Not only do these methods show their age and artificially limit their scope to the lowest denominator then, but they also cost code size (due to prefixes or extra ANDs) and performance (e.g. because of partial register stalls).

---
Herbert Duerr
du...@sun.com

Registered Office: Sun Microsystems GmbH
  Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Commercial register of the Local Court of Munich: HRB 161028
Managing Directors: Thomas Schroeder
Chairman of the Supervisory Board: Martin Haering

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.org
For additional commands, e-mail: dev-h...@openoffice.org

Reply via email to