> This is my suggestion - ask yourself: - Are the copyrights in the header correct? - Have the file changed significantly from their original? - Is the 3rd party code just part of the files or the entire file?
So for [5] I can say the copyright headers seem to be correct, the file is basically unchanged from the original (which is from Scala/EPFL) and the 3rd party code is for the entire file. [9] is slightly more complicated, the file originally had no header and it was copied from https://github.com/lagom/online-auction-java/blob/1.4.x/bidding-impl/src/main/java/com/example/auction/bidding/impl/AuctionEntity.java (as noted in the comment) which is actually from the same company (Lightbend) behind Akka. My assumption here is that they didn't bother putting in a header because it was the same company (Akka and Lagom both owned by Lightbend). You can make an argument that the change that Akka did to that file is significant in the sense that they converted the sample code from one type of Actor System untyped to typed but IANAL. In this case the entire file is also 3rd party code. > I’d use the original header. Correct me if I am wrong, but I don't think there is ever a case where we changed an original header. If we did do something header wise, it would be just adding the ASF header above the original. Some of these cases do genuinely seem that Akka/Lightbend forgot to put in headers when they should have. On Mon, Jun 19, 2023 at 5:21 PM Justin Mclean <[email protected]> wrote: > Hi, > > > [5] to [9] are all files that originated from non-Lightbend sources - > > there are issues tracking all these files in the Pekko issues tracker. > > > > Most of these files were added more than 10 years ago. I'm not sure > > how we are going to improve on the header situation. > > This is my suggestion - ask yourself: > - Are the copyrights in the header correct? > - Have the file changed significantly from their original? > - Is the 3rd party code just part of the files or the entire file? > > If the copywriter are incorrect OR file contents have not changed > significantly (say more than 1/2 and porting to a new language or > reformatting isn’t a “change”) and the 3rd party code is the majority of > the file, I’d use the original header. > > Or another approach might be, keep the header but a comment in it, adding > the 3rd party copyright(s) and license to make it clear that the standard > header may not apply to all the code in the file. > > Kind Regards, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
