Hi, Sorry it’s -1 (binding) from me as: - The zip are tar file names are different e.g. CustomGuardianAndMaterializerTest.java in one, CustomGuardianAndMaterializerTest.j in the other. This looks to be a file path length issue? - LICENSE missing license and mention of 3rd party code in the source
I checked: - incubating name - signatures and hashes are correct - DISCLAIMER exists - LICENSE seems to be missing some licensed code, e.g. [2][3][4] - LICENSE is missing 3rd party code mentioned in [10][11][13][14][15][16] - LICENSE is possibly missing 3rd party code mentioned in [12] - I may have missed some other 3rd party code that should be included in LICENSE as I just manually spot checked a few likely files. - LICENSE mentions that code from scala-collection-compat and scala-library are Copyright (c) 2002-2023 EPFL and Copyright (c) 2011-2023 Lightbend, Inc. but their headers state only Copyright (c) 2011-2023 Lightbend, Inc. - NOTICE includes info on MurmurHash.scala which is under the public domain, so it doesn’t need to be included in NOTICE. - NOTICE repeats license information for scala-collection-compat and scala-library, which is probably not needed, but I can see why it was included. - No unexpected binaries - These file may have incorrect Pekko headers [5][6][7][8][9]? All of these files are mentioned in the licence as 3rd party code, so they should ideally have their original headers. Did Akka incorrectly change the headers? Some minor issues (none of these should attract a -1 vote): - The KEYS file needs to be placed in [1] as that is used to verify all releases. - It would be better to sign the artefacts with an apache.org email, not a yahoo.com one. - it would be nice if the zip was unzipped into a directory, not the current directory. - It would be nice to be more explicit on the parts mentioned in LICENSE, i.e. include paths of files I didn’t try compiling from source. I would leave this vote open for a few days to see if anyone else finds different issues. Kind Regards, Justin 1. https://dist.apache.org/repos/dist/release/incubator/pekko/ 2. ./remote/src/test/java/org/apache/pekko/remote/artery/aeron/AeronStat.java 3. ./remote/src/test/java/org/apache/pekko/remote/artery/RateReporter.java 4. ./remote/src/main/java/org/apache/pekko/remote/artery/aeron/AeronErrorLog.java 5. ./actor/src/main/scala/org/apache/pekko/routing/MurmurHash.scala 6. ./actor/src/main/scala/org/apache/pekko/io/dns/DnsSettings.scala 7. ./cluster/src/main/scala/org/apache/pekko/cluster/VectorClock.scala 8. ./remote/src/main/java/org/apache/pekko/remote/artery/compress/CountMinSketch.java 9. ./persistence-typed/src/test/java/jdocs/org/apache/pekko/persistence/typed/auction/AuctionEntity.java 10. ./actor/src/main/java/org/apache/pekko/dispatch/AbstractBoundedNodeQueue.java 11. ./actor/src/main/scala/org/apache/pekko/util/FrequencySketch.scala 12. ./actor/src/main/scala/org/apache/pekko/util/FrequencySketch.scala 13. ./remote/src/main/java/org/apache/pekko/remote/artery/compress/CountMinSketch.java 14. ./actor/src/main/scala/org/apache/pekko/util/PrettyByteString.scala 15 ./actor/src/main/scala/org/apache/pekko/util/UUIDComparator.scala 16. ./persistence-typed/src/test/java/jdocs/org/apache/pekko/persistence/typed/auction/AuctionEntity.java --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
