Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14852114
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseTenantSpecificViewIndexIT.java
---
@@ -117,26 +139,38 @@ private Connection createTenantConnection(String
tenantId) throws SQLException {
private void verifyViewData(Connection conn, String valuePrefix)
throws SQLException {
String query = "SELECT k1, k2, v2 FROM v WHERE v2='" + valuePrefix
+ "v2-1'";
ResultSet rs = conn.createStatement().executeQuery(query);
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(1, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(3, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(5, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(7, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
- assertTrue(rs.next());
- assertEquals(1, rs.getInt(1));
- assertEquals(9, rs.getInt(2));
- assertEquals(valuePrefix + "v2-1", rs.getString(3));
+ List<List<Object>> expectedResultsA = Lists.newArrayList(
+ Arrays.<Object>asList(1,1, valuePrefix + "v2-1"),
+ Arrays.<Object>asList(1,3, valuePrefix + "v2-1"),
+ Arrays.<Object>asList(1,5, valuePrefix + "v2-1"),
+ Arrays.<Object>asList(1,7, valuePrefix + "v2-1"),
+ Arrays.<Object>asList(1,9, valuePrefix + "v2-1"));
+ assertValuesEqualsResultSet(rs,expectedResultsA);
assertFalse(rs.next());
}
+
--- End diff --
This code looks familiar. If it matches original (I think from QueryIT),
can you move it into the base test class instead of copy/paste?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
