Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14855032
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java
---
@@ -54,7 +55,8 @@ protected
SkipRangeParallelIteratorRegionSplitter(StatementContext context, Tabl
public List<HRegionLocation> filterRegions(List<HRegionLocation>
allTableRegions, final ScanRanges ranges) {
Iterable<HRegionLocation> regions;
- if (ranges == ScanRanges.EVERYTHING) {
+ if (ranges == ScanRanges.EVERYTHING
--- End diff --
This shouldn't be necessary and will cause the skip scan not to be used
(which will be horrible for point queries). It should work fine to do the skip
scan for each region (much better than doing a full region scan for every
region).
Can you remove it and add a test that does a point lookup with multiple
values (for example, a IN clause with multiple values for an indexed column)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
