Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/1#discussion_r14853783
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
 ---
    @@ -100,7 +109,7 @@ public static void serializeIntoScan(Scan scan, int 
thresholdBytes, int limit, L
             }
         }
         
    -    public static OrderedResultIterator deserializeFromScan(Scan scan, 
RegionScanner s) {
    +    public static OrderedResultIterator deserializeFromScan(Scan scan, 
RegionScanner s, int offset) {
    --- End diff --
    
    bq. There's a bit more you need to do to handle ORDER BY correctly. It'd be 
for the case in which a data column was referenced in the ORDER BY while the 
index table is being used to satisfy the query.
    This is working fine James. I have added test case. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to