Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14858124
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java
---
@@ -54,7 +55,8 @@ protected
SkipRangeParallelIteratorRegionSplitter(StatementContext context, Tabl
public List<HRegionLocation> filterRegions(List<HRegionLocation>
allTableRegions, final ScanRanges ranges) {
Iterable<HRegionLocation> regions;
- if (ranges == ScanRanges.EVERYTHING) {
+ if (ranges == ScanRanges.EVERYTHING
--- End diff --
Even with the change skip scan will be used James. The change is required
because the key ranges generated by compiler won't be in the local index
regions key range because local index rows have prefixed region start key
extra. Without the change mostly no region will be selected for scanning.
QueryIT#testSimpleInListStatement is the test case verifies the same.
Here is the explain query result.
CLIENT PARALLEL 4-WAY SKIP SCAN ON 2 KEYS OVER _LOCAL_IDX_ATABLE [-32768,2]
- [-32768,4]
SERVER FILTER BY FIRST KEY ONLY AND ORGANIZATION_ID = '00D300000000XHP'
CLIENT MERGE SORT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
