Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14853806
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -51,21 +51,38 @@ public static void doSetup() throws Exception {
props.put(QueryServices.MAX_INTRA_REGION_PARALLELIZATION_ATTRIB,
Integer.toString(1));
// Forces server cache to be used
props.put(QueryServices.INDEX_MUTATE_BATCH_SIZE_THRESHOLD_ATTRIB,
Integer.toString(2));
+ props.put(QueryServices.DROP_METADATA_ATTRIB,
Boolean.toString(true));
// Must update config before starting server
startServer(getUrl(), new
ReadOnlyProps(props.entrySet().iterator()));
}
-
+
@Test
public void testIndexWithNullableFixedWithCols() throws Exception {
+ testIndexWithNullableFixedWithCols(false);
+ }
+
+ @Test
+ public void testLocalIndexWithNullableFixedWithCols() throws Exception
{
+ testIndexWithNullableFixedWithCols(true);
+ }
+
+ private void testIndexWithNullableFixedWithCols(boolean localIndex)
throws Exception {
Properties props = new Properties(TEST_PROPERTIES);
Connection conn = DriverManager.getConnection(getUrl(), props);
conn.setAutoCommit(false);
try {
createTestTable();
populateTestTable();
- String ddl = "CREATE INDEX " + INDEX_TABLE_NAME + " ON " +
DATA_TABLE_FULL_NAME
- + " (char_col1 ASC, int_col1 ASC)"
- + " INCLUDE (long_col1, long_col2)";
+ String ddl = null;
+ if(localIndex){
+ ddl = "CREATE INDEX " + INDEX_TABLE_NAME + " ON " +
DATA_TABLE_FULL_NAME
--- End diff --
This is the actual code. Earlier by mistake I missed to add LOCAL in if
branch so if else branches are same.
if (localIndex) {
ddl = "CREATE LOCAL INDEX " + INDEX_TABLE_NAME + " ON " +
DATA_TABLE_FULL_NAME + " (date_col)";
} else {
ddl = "CREATE INDEX " + INDEX_TABLE_NAME + " ON " +
DATA_TABLE_FULL_NAME + " (date_col)";
}
Now I have corrected it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
