Hi Chris, Let me think about the variable name -- I have no problem with longer names, if that makes the code more readable.
I *think* that sounds right to restore the original text, but let me see if I can get the code to do that. Probably on the open it could save the content and restore it on ESCAPE. I will try that and repost the diff to the JIRA issue. Thanks for looking at this. ~Roger Whitcomb -----Original Message----- From: Chris Bartlett [mailto:cbartlet...@gmail.com] Sent: Wed 6/22/2011 5:38 AM To: dev@pivot.apache.org Subject: Re: Focus transfer when suggestion popup closes Roger, Looks good to me. Would something like 'refocusTextInput' more clearly explain the flag's purpose, or even the verbose 'returnFocusToTextInput'? Just a personal preference for long variable and method names, so feel free to ignore :) While testing I noticed that pressing ESCAPE to close the SuggestionPopup window does not reset the the TextInput's content if it has been changed (via the UP/DOWN arrow keys). My assumption was that the first time a ListView item is selected, the TextInput's content would be saved and restored if ESCAPE was used to close the popup window. Does this sound right? Chris On 22 June 2011 01:56, Roger L. Whitcomb <roger.whitc...@ingres.com> wrote: > Chris, > The patch is already attached to the JIRA ticket. Thanks. > > Roger Whitcomb | Architect, Engineering | roger.whitc...@ingres.com | > Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 | > USA +1 650-587-5596 | fax: +1 650-587-5550 > -----Original Message----- > From: Chris Bartlett [mailto:cbartlet...@gmail.com] > Sent: Tuesday, June 21, 2011 11:52 AM > To: dev@pivot.apache.org > Subject: Re: Focus transfer when suggestion popup closes > > Roger, > > I think the mailing list accepts zipped patches if you want to try again > (as > the inline one came out garbled in GMail). > > But now that you have created a JIRA ticket, it might be easier to just > attacy the patch there for review. > > I'll take a look tomorrow if not before. > > Chris >
