[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382696#comment-16382696
]
Roger Whitcomb commented on PIVOT-1032:
---------------------------------------
Checked in a new "pivot_styles.xml" which is the default "sun_checks.xml" but
with a LineLength max of 110 (instead of default 80), which reduces the number
of "errors" by around 10,000. Now "only" 34,263 errors with these changes:
Adding pivot_checks.xml
Sending tests/src/org/apache/pivot/tests/GaugeTest.java
Sending wtk/src/org/apache/pivot/wtk/CSSColor.java
Sending wtk/src/org/apache/pivot/wtk/util/ColorUtilities.java
Sending wtk/test/org/apache/pivot/wtk/test/BoundsTest.java
Sending wtk/test/org/apache/pivot/wtk/test/ColorUtilitiesTest.java
Sending wtk/test/org/apache/pivot/wtk/test/GaugeTest.java
Sending wtk/test/org/apache/pivot/wtk/test/InsetsTest.java
Sending wtk/test/org/apache/pivot/wtk/test/MeterTest.java
Transmitting file data .........done
Committing transaction...
Committed revision 1825686.
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
